Bug 12539
| Summary: | [PATCH] Fix a panic with 1M of shared memory, no GTT entries | ||
|---|---|---|---|
| Product: | Drivers | Reporter: | Lubomir Rintel (lkundrak) |
| Component: | Video(AGP) | Assignee: | Dave Airlie (airlied) |
| Status: | CLOSED CODE_FIX | ||
| Severity: | normal | CC: | abittner, akpm |
| Priority: | P1 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Kernel Version: | 2.6.18 | Subsystem: | |
| Regression: | --- | Bisected commit-id: | |
| Attachments: |
Fix that applies against current linux-2.6 head
Fix that applies against RHEL-5 kernel |
||
|
Description
Lubomir Rintel
2009-01-25 13:04:10 UTC
Created attachment 19983 [details]
Fix that applies against current linux-2.6 head
Created attachment 19984 [details]
Fix that applies against RHEL-5 kernel
I did not test the fix with HEAD, but applying this one to el5 kernel worked fine for me (no crash).
Please prefer to send patches by email rather than through bugzilla? Suitable recipients for this one are: Dave Airlie <airlied@linux.ie> Andrew Morton <akpm@linux-foundation.org> linux-kernel@vger.kernel.org stable@kernel.org Thanks. What happens with my hardware configuration is this:
469 static void intel_i830_init_gtt_entries(void)
...
size is set to 1024K
516 case G33_PGETBL_SIZE_1M:
517 size = 1024;
518 break;
...
and incremented by 4K
528 size += 4;
...
Size of shared memory is 1M, thus gtt_entries becomes -4K here
566 case I855_GMCH_GMS_STOLEN_1M:
567 gtt_entries = MB(1) - KB(size);
568 break;
...
And subsequently -1 here
642 gtt_entries /= KB(4);
...
974 static int intel_i915_configure(void)
...
Which causes this cycle to iterate once, until it reaches zero, which shouldn't happen
995 for (i = intel_private.gtt_entries; i < current_size->num_entries; i++) {
996 writel(agp_bridge->scratch_page, intel_private.gtt+i);
997 }
(In reply to comment #3) > Please prefer to send patches by email rather than through bugzilla? Sorry, I'm new at this. I'll try to post future patches by mail. Should I also resend this one? > Suitable recipients for this one are: > > Dave Airlie <airlied@linux.ie> > Andrew Morton <akpm@linux-foundation.org> > linux-kernel@vger.kernel.org > stable@kernel.org How could I have guessed these? I guess I'd find Dave in MAINTAINERS file in kernel tree. Is my guess that stable@ is for patches against linux-2.6 tree and all patches should go to linux-kernel@ right? Thanks! (In reply to comment #5) > Sorry, I'm new at this. I'll try to post future patches by mail. Should I > also > resend this one? yes please. > > Suitable recipients for this one are: > > > > Dave Airlie <airlied@linux.ie> > > Andrew Morton <akpm@linux-foundation.org> > > linux-kernel@vger.kernel.org > > stable@kernel.org > > How could I have guessed these? erm, good question. Ask me :) > I guess I'd find Dave in MAINTAINERS file in > kernel tree. Is my guess that stable@ is for patches against linux-2.6 tree > and > all patches should go to linux-kernel@ right? Thanks! > Yep, close enough |