Most recent kernel where this bug did not occur: 2.6.23-rc2 (maybe rc3) Distribution: ubuntu Hardware Environment: Toshiba Tecra 8000 Laptop (P3) Software Environment: Problem Description: the fan doesn't work any more...isected it to that one: cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b Author: Alexey Starikovskiy <astarikovskiy@suse.de> Date: Fri Aug 3 17:52:48 2007 -0400 ACPI: EC: If ECDT is not found, look up EC in DSDT. Some ASUS laptops access EC space from device _INI methods, but do not provide ECDT for early EC setup. In order to make them function properly, there is a need to find EC is DSDT before any _INI is called. Similar functionality was turned on by acpi_fake_ecdt=1 command line before. Now it is on all the time. http://bugzilla.kernel.org/show_bug.cgi?id=8598 Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> Signed-off-by: Len Brown <len.brown@intel.com> Steps to reproduce: boot (or try to)
Created attachment 12622 [details] patch fixing the problem from Alexey Starikovskiy <astarikovskiy@suse.de>
Created attachment 12623 [details] dmesg of 2.6.23-rc4 with patch with the fixup patch because it doesn't boot up to a writeable file system. (and i don't find my serial cable)
Created attachment 12624 [details] acpidump output
Reply-To: akpm@linux-foundation.org On Wed, 29 Aug 2007 13:47:36 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=8958 > > Summary: regression: fan doesn't work anymore > Product: ACPI > Version: 2.5 > KernelVersion: 2.6.23-rc4 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: blocking > Priority: P1 > Component: Other > AssignedTo: acpi_other@kernel-bugs.osdl.org > ReportedBy: daniel.ritz@gmx.ch > > > Most recent kernel where this bug did not occur: 2.6.23-rc2 (maybe rc3) > Distribution: ubuntu > Hardware Environment: Toshiba Tecra 8000 Laptop (P3) > Software Environment: > Problem Description: > the fan doesn't work any more...isected it to that one: > > cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit > commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b > Author: Alexey Starikovskiy <astarikovskiy@suse.de> > Date: Fri Aug 3 17:52:48 2007 -0400 > > ACPI: EC: If ECDT is not found, look up EC in DSDT. > > Some ASUS laptops access EC space from device _INI methods, but do not > provide ECDT for early EC setup. In order to make them function properly, > there is a need to find EC is DSDT before any _INI is called. > > Similar functionality was turned on by acpi_fake_ecdt=1 command line > before. Now it is on all the time. > > http://bugzilla.kernel.org/show_bug.cgi?id=8598 > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> > Signed-off-by: Len Brown <len.brown@intel.com> > Steps to reproduce: boot (or try to) > I'm not sure that I understand this report ;) Michal, pleas track it as a post-2.6.22 regression. Daniel, if you have a patch which you think is needed for 2.6.23 can you please send it?
On 30/08/2007, Andrew Morton <akpm@linux-foundation.org> wrote: > On Wed, 29 Aug 2007 13:47:36 -0700 (PDT) bugme-daemon@bugzilla.kernel.org > wrote: > > > http://bugzilla.kernel.org/show_bug.cgi?id=8958 > > > > Summary: regression: fan doesn't work anymore > > Product: ACPI > > Version: 2.5 > > KernelVersion: 2.6.23-rc4 > > Platform: All > > OS/Version: Linux > > Tree: Mainline > > Status: NEW > > Severity: blocking > > Priority: P1 > > Component: Other > > AssignedTo: acpi_other@kernel-bugs.osdl.org > > ReportedBy: daniel.ritz@gmx.ch > > > > > > Most recent kernel where this bug did not occur: 2.6.23-rc2 (maybe rc3) > > Distribution: ubuntu > > Hardware Environment: Toshiba Tecra 8000 Laptop (P3) > > Software Environment: > > Problem Description: > > the fan doesn't work any more...isected it to that one: > > > > cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b is first bad commit > > commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b > > Author: Alexey Starikovskiy <astarikovskiy@suse.de> > > Date: Fri Aug 3 17:52:48 2007 -0400 > > > > ACPI: EC: If ECDT is not found, look up EC in DSDT. > > > > Some ASUS laptops access EC space from device _INI methods, but do not > > provide ECDT for early EC setup. In order to make them function > properly, > > there is a need to find EC is DSDT before any _INI is called. > > > > Similar functionality was turned on by acpi_fake_ecdt=1 command line > > before. Now it is on all the time. > > > > http://bugzilla.kernel.org/show_bug.cgi?id=8598 > > > > Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de> > > Signed-off-by: Len Brown <len.brown@intel.com> > > Steps to reproduce: boot (or try to) > > > > I'm not sure that I understand this report ;) > > Michal, pleas track it as a post-2.6.22 regression. I'm tracking this already Subject : the fan doesn't work any more References : http://lkml.org/lkml/2007/8/28/359 Last known good : ? Submitter : Daniel Ritz <daniel.ritz-ml@swissonline.ch> Caused-By : Alexey Starikovskiy <astarikovskiy@suse.de> commit cd8c93a4e04dce8f00d1ef3a476aac8bd65ae40b Handled-By : Alexey Starikovskiy <astarikovskiy@suse.de> Patch : http://lkml.org/lkml/2007/8/29/15 Status : patch was suggested > > Daniel, if you have a patch which you think is needed for 2.6.23 can > you please send it? > Status : patch was suggested Regards, Michal
Created attachment 12626 [details] Revive acpi_fake_ecdt kernel option Daniel, Could you please check if the following patch helps as well? Also, I don't understand why plain -rc4 breaks for you, as your system does not have EC at all, and acpi_get_devices() should just return NOT_FOUND error code. Could you please make a screen shot of hanged system if you cant get a dmesg from it?
Created attachment 12627 [details] Check if boot_ec was really found I was wrong about acpi_get_devices() -- it happily return AE_OK if no device was found. Please check that this minimal patch makes your system boot as before.
yes, that one (attachment 12627 [details]) works. and it makes perfect sense. thanks. please push upstream.
2d8348b429b4ae5cc47449c787881221fe43af4b ACPI: EC: Check if boot_ec was really found in DSDT shipped in 2.6.23-rc4-git3 closed.