Bug 6740 - Size of initramfs_data.cpio.gz is doubled.
Summary: Size of initramfs_data.cpio.gz is doubled.
Status: CLOSED CODE_FIX
Alias: None
Product: Other
Classification: Unclassified
Component: klibc/kinit (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Sam Ravnborg
URL:
Keywords:
: 6741 6742 6743 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-06-24 02:23 UTC by thomas
Modified: 2006-08-03 14:03 UTC (History)
0 users

See Also:
Kernel Version: 2.6.17
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description thomas 2006-06-24 02:23:12 UTC
Most recent kernel where this bug did not occur:2.6.16
Distribution:
Hardware Environment:
Software Environment:
Problem Description:
gen_initramfs_list.sh concatenates two identical cpio-archives.

Bug in usr/Makefile:
ramfs-input := $(if $(filter-out "",$(CONFIG_INITRAMFS_SOURCE)), \
                    $(CONFIG_INITRAMFS_SOURCE),-d)
ramfs-args  := \
        $(if $(CONFIG_INITRAMFS_ROOT_UID), -u $(CONFIG_INITRAMFS_ROOT_UID)) \
        $(if $(CONFIG_INITRAMFS_ROOT_GID), -g $(CONFIG_INITRAMFS_ROOT_GID)) \
        $(ramfs-input)


# .initramfs_data.cpio.gz.d is used to identify all files included
# in initramfs and to detect if any files are added/removed.
# Removed files are identified by directory timestamp being updated
# The dependency list is generated by gen_initramfs.sh -l
ifneq ($(wildcard $(obj)/.initramfs_data.cpio.gz.d),)
        include $(obj)/.initramfs_data.cpio.gz.d
endif

quiet_cmd_initfs = GEN     $@
      cmd_initfs = $(initramfs) -o $@ $(ramfs-args) $(ramfs-input)
                                                    ^^^^^^^^^^^^^^

Patch:
--- Makefile.orig       2006-06-24 11:04:58.060163593 +0200
+++ Makefile    2006-06-24 10:35:52.551677940 +0200
@@ -33,7 +33,7 @@
 endif

 quiet_cmd_initfs = GEN     $@
-      cmd_initfs = $(initramfs) -o $@ $(ramfs-args) $(ramfs-input)
+      cmd_initfs = $(initramfs) -o $@ $(ramfs-args)

 targets := initramfs_data.cpio.gz
 $(deps_initramfs): klibcdirs



Steps to reproduce: ...
Comment 1 Nishanth Aravamudan 2006-06-24 09:07:39 UTC
*** Bug 6741 has been marked as a duplicate of this bug. ***
Comment 2 Nishanth Aravamudan 2006-06-24 09:08:24 UTC
*** Bug 6742 has been marked as a duplicate of this bug. ***
Comment 3 Nishanth Aravamudan 2006-06-24 09:08:58 UTC
*** Bug 6743 has been marked as a duplicate of this bug. ***
Comment 4 Sam Ravnborg 2006-08-03 14:03:00 UTC
Thanks for the report.
This was fixed in 2.6.17
/Sam

Note You need to log in before you can comment on or make changes to this bug.