Bug 13629 - option: oops on usb-modem removal
Summary: option: oops on usb-modem removal
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: USB (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Greg Kroah-Hartman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-26 18:10 UTC by Kirill Smelkov
Modified: 2009-07-06 17:41 UTC (History)
0 users

See Also:
Kernel Version: 2.6.29.5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
option-oops-on-modem-removal.dmesg (25.16 KB, text/plain)
2009-06-26 18:10 UTC, Kirill Smelkov 		Details
option-oops-on-modem-removal.dmesg-2.6.30 (178.41 KB, text/plain)
2009-06-29 16:30 UTC, Kirill Smelkov 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Kirill Smelkov 2009-06-26 18:10:42 UTC 
Created attachment 22108 [details]
option-oops-on-modem-removal.dmesg

I've setup Huawei E156G USB modem to work with pppd on 2.6.29.5

However, when I unplug the device, there is a chance (not every time) to get an oops in option_close. It seems there is some race...

Oops, log attached.

Thanks beforehand,
Kirill
Comment 1 Greg Kroah-Hartman 2009-06-26 18:31:22 UTC 
Please try 2.6.30.
Comment 2 Kirill Smelkov 2009-06-29 16:30:01 UTC 
Created attachment 22141 [details]
option-oops-on-modem-removal.dmesg-2.6.30

[Trying 2.6.30 on a different, much faster host, but anyway]

I'm still observing the same behaviour. Kernel logs for 3 reboots attached.
Comment 3 Kirill Smelkov 2009-07-06 17:41:58 UTC 
It seems this has been fixed in 2.6.30.1 -- I've tried ~ 10 times plugging/unplugging modem, and now there is no oops. I suspect the following commit to be the cure

b6cd9d / f9c99b (usb-serial: replace shutdown with disconnect, release)

Thanks!
Note You need to log in before you can comment on or make changes to this bug.