Latest working kernel version: none Earliest failing kernel version: none Distribution: none Hardware Environment: Macbook Air Software Environment: ubuntu Problem Description: The touchpad on the new Macbook Air and Macbook Pro Penryn are not supported by the current drivers. As a consequence, the synaptics system does not work on those computers, and the mouse handling is very poor. The attached driver, bcm5974, remedies this. It operates the same way as the appletouch driver, and could preferrably be added to the same place, drivers/input/mouse/. Steps to reproduce: none
Created attachment 16625 [details] bcm5974.c: Apple USB BCM5974 Multitouch device driver The source file can also be found here http://web.comhem.se/rydberg/Bits/, and soon also on sourcefourge. The driver is in a beta state.
Please don't submit patches via bugzilla. Send it via email as per Documentation/SubmittingPatches. Suitable sendees would be linux-input@vger.kernel.org linux-kernel@vger.kernel.org Andrew Morton <akpm@linux-foundation.org> Dmitry Torokhov <dtor@mail.ru> Before doing this please pass the code through scripts/checkpatch.pl. At present checkpatch reports total: 347 errors, 14 warnings, 669 lines checked which we wold prefer be fixed. Thanks.
The driver appears to be based on the appletouch driver. Is there a chance that support for the new device type be foldedinto the original driver?
That was the original intention, but as the facts unfolded, it seemed too intrusive to put it in the same file. These are the major reasons: 1. The data model for appletouch is quite different from bcm5974. The former reads delta information and accumulates the absolute information. The latter reads the absolute information directly. 2. The bcm9574 requires connection to two usb endpoints, appletouch uses a single one. 3. The bcm9574 is an empirical driver, working against a brand new, partly unknown, device with yet unexplored potential. It is expected that as more is learnt about this device, new features will be added. I fear regression would be the result of trying to add new features to the old driver. I will resubmit the driver as a mail shortly, as required.
This was added in commit f89bd95c5c946776f116ffeb997653d4193d6a35