Bug 9698 - arch/arm/mach-at91/board-ek.c compile error
Summary: arch/arm/mach-at91/board-ek.c compile error
Status: CLOSED CODE_FIX
Alias: None
Product: Platform Specific/Hardware
Classification: Unclassified
Component: ARM (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: David Brownell
URL:
Keywords:
Depends on:
Blocks: 9243
  Show dependency tree
 
Reported: 2008-01-05 14:49 UTC by Adrian Bunk
Modified: 2008-01-11 13:21 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.24-rc6
Subsystem:
Regression: Yes
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Adrian Bunk 2008-01-05 14:49:48 UTC 
Commit f230d3f53d72d05bcb5666ab7e2eccd49c8b3a15 causes the following compile error with at91rm9200ek_defconfig:

<--  snip  -->

...
  CC      arch/arm/mach-at91/board-ek.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/arm/mach-at91/board-ek.c: In function 'ek_board_init':
/home/bunk/linux/kernel-2.6/git/linux-2.6/arch/arm/mach-at91/board-ek.c:148: error: 'ek_i2c_devices' undeclared (first use in this function)
...
make[2]: *** [arch/arm/mach-at91/board-ek.o] Error 1

<--  snip  -->
Comment 1 Anonymous Emailer 2008-01-05 15:17:26 UTC 
Reply-To: david-b@pacbell.net

On Saturday 05 January 2008, you wrote:
> snip  -->
> 
> ...
>   CC      arch/arm/mach-at91/board-ek.o
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/arm/mach-at91/board-ek.c: In
> function 'ek_board_init':
> /home/bunk/linux/kernel-2.6/git/linux-2.6/arch/arm/mach-at91/board-ek.c:148:
> error: 'ek_i2c_devices' undeclared (first use in this function)
> ...
> make[2]: *** [arch/arm/mach-at91/board-ek.o] Error 1
> 
> <--  snip  -->
> 

Fix has been available for the last month or so:

http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=4691/1
Comment 2 David Brownell 2008-01-05 15:23:00 UTC 
... oh, and for the record, the signoffs on f230d3f53d72d05bcb5666ab7e2eccd49c8b3a15
are incorrect.  This combines two patches which
I wrote, but adds significant changes from Andrew.
The two patches I wrote were individually correct.
Comment 3 Adrian Bunk 2008-01-11 13:21:02 UTC 
Fixed by commit 430cb436103ce1b58cb80e7c3d44f4d4a8110caa in Linus' tree.
Note You need to log in before you can comment on or make changes to this bug.