Bug 9467 - NIC sis 191 failed
NIC sis 191 failed
Status: CLOSED CODE_FIX
Product: Drivers
Classification: Unclassified
Component: Network
All Linux
: P1 high
Assigned To: Francois Romieu
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-28 09:35 UTC by WIPAT SRUTIPROM
Modified: 2009-09-21 20:22 UTC (History)
5 users (show)

See Also:
Kernel Version: 2.6.23
Tree: Fedora
Regression: ---


Attachments
Bridge search update (1.40 KB, application/octet-stream)
2007-11-29 15:22 UTC, Francois Romieu
Details
unmodified copy of 'sis190.c' file from ubuntu 7.10; ubuntu kernel '2.6.22-14-generic' (12.76 KB, application/octet-stream)
2008-01-12 17:44 UTC, M. Emal Alekozai
Details

Description WIPAT SRUTIPROM 2007-11-28 09:35:46 UTC
Most recent kernel where this bug did not occur:
Distribution: fedora 8
Hardware Environment: NIC integrated on mainboard ASUSTeK P5S-MX SE
Software Environment:  fedora 8 live CD
Problem Description: 
part of output from "lspci -nn" :
...
00:04.0 Ethernet controller [0200]: Silicon Integrated Systems [SiS] 191 Gigabit Ethernet Adapter [1039:0191] (rev 02)
... 
part of output from "dmseg":
...
sis190 Gigabit Ethernet driver 1.2 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A] -> GSI 19 (level, low) -> IRQ 16
PCI: Setting latency timer of device 0000:00:04.0 to 64
0000:00:04.0: Read MAC address from APC.
0000:00:04.0: Can not find ISA bridge.
ACPI: PCI interrupt for device 0000:00:04.0 disabled
sis190: probe of 0000:00:04.0 failed with error -5
... 

Steps to reproduce:
Comment 1 Francois Romieu 2007-11-29 15:22:10 UTC
Created attachment 13803 [details]
Bridge search update

Can you try the attached patch against current 2.6.24-rc ?

-- 
Ueimor
Comment 2 Juan Jose Pablos 2007-11-30 01:43:58 UTC
It works here.
Tested on a Acer Extensa E261   with chipset SiS 672 / SiS968
patched against 2.6.24-rc3
Comment 3 WIPAT SRUTIPROM 2007-12-01 23:33:22 UTC
Successful tested patched with 2.6.23.09 on mainboard ASUSTeK P5S-MX SE
part of output of "dmseg":
...
sis190 Gigabit Ethernet driver 1.2 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A] -> GSI 19 (level, low) -> IRQ 16
PCI: Setting latency timer of device 0000:00:04.0 to 64
0000:00:04.0: Read MAC address from APC.
0000:00:04.0: Unknown PHY transceiver at address 1.
0000:00:04.0: Using transceiver at address 1 as default.
0000:00:04.0: SiS 191 PCI Gigabit Ethernet adapter at f8828c00 (IRQ: 16), 00:1d:60:0b:14:3d
eth0: RGMII mode.
eth0: Enabling Auto-negotiation. 
...
Thanks and wait for stable version.

--WIPAT
Comment 4 Juan Jose Pablos 2007-12-02 03:54:23 UTC
WIPAT,
are you having performance issues with this card?
Comment 5 WIPAT SRUTIPROM 2007-12-02 08:19:30 UTC
All fine, no any problem.

--WIPAT
Comment 6 Mimosinnet 2007-12-26 14:21:26 UTC
I have also successfully tested the patch on 2.6.23-r3 kernel (fujitsu esprimo mobile). 

# uname -a
Linux ninlug 2.6.23-gentoo-r3 #10 SMP Tue Dec 25 22:52:55 CET 2007 x86_64 Intel(R) Core(TM)2 Duo CPU T5450 @ 1.66GHz GenuineIntel GNU/Linux

# lspci -nn
00:02.0 ISA bridge [0601]: Silicon Integrated Systems [SiS] SiS968 [MuTIOL Media IO] [1039:0968] (rev 01)
00:04.0 Ethernet controller [0200]: Silicon Integrated Systems [SiS] 191 Gigabit Ethernet Adapter [1039:0191] (rev 02)

# dmesg
sis190 Gigabit Ethernet driver 1.2 loaded.
ACPI: PCI Interrupt 0000:00:04.0[A] -> GSI 19 (level, low) -> IRQ 19
PCI: Setting latency timer of device 0000:00:04.0 to 64
0000:00:04.0: Read MAC address from APC.
0000:00:04.0: Unknown PHY transceiver at address 1.
0000:00:04.0: Using transceiver at address 1 as default.
0000:00:04.0: SiS 191 PCI Gigabit Ethernet adapter at ffffc200001f6000 (IRQ: 19), 00:a0:d1:cb:64:4e
Comment 7 M. Emal Alekozai 2008-01-12 17:38:39 UTC
Hi,
I got the same problem as described in the bug description (WIPAT SRUTIPROM
2007-11-28). I tried the patch (paths adjusted for Ubuntu) against the
2.6.22-14 kernel. For the patching I get the following error:
 
root@ubuntu:/usr/src/linux-source-2.6.22/drivers/net# patch -p0 </root/zozPathModified 
patching file sis190.c
Hunk #1 FAILED at 1549.
1 out of 1 hunk FAILED -- saving rejects to file sis190.c.rej

Could you send me a patch for the 2.6.22 Ubuntu version of sis190.c (file attached 'sis190_ubuntu2.6.22-14-generic.gz'), or at least tell me how to solve the patching error?

Thanks Emal


Distribution: Ubuntu 7.10 (Gutsy Gibson, released 2007/10/18)
Laptop: Fujitsu Siemens Esprimo V5535
Hardware Environment: SiS191, integrated on mainboard
Software Environment: Ubuntu installed, kernel 2.6.22-14-generic

$ lspci -nn
00:00.0 Host bridge [0600]: Silicon Integrated Systems [SiS] 671MX [1039:0671]
00:01.0 PCI bridge [0604]: Silicon Integrated Systems [SiS] SiS AGP Port (virtual PCI-to-PCI bridge) [1039:0003]
00:02.0 ISA bridge [0601]: Silicon Integrated Systems [SiS] SiS968 [MuTIOL Media IO] [1039:0968] (rev 01)
00:02.5 IDE interface [0101]: Silicon Integrated Systems [SiS] 5513 [IDE] [1039:5513] (rev 01)
00:03.0 USB Controller [0c03]: Silicon Integrated Systems [SiS] USB 1.0 Controller [1039:7001] (rev 0f)
00:03.1 USB Controller [0c03]: Silicon Integrated Systems [SiS] USB 1.0 Controller [1039:7001] (rev 0f)
00:03.3 USB Controller [0c03]: Silicon Integrated Systems [SiS] USB 2.0 Controller [1039:7002]
00:04.0 Ethernet controller [0200]: Silicon Integrated Systems [SiS] 191 Gigabit Ethernet Adapter [1039:0191] (rev 02)
00:05.0 IDE interface [0101]: Silicon Integrated Systems [SiS] SATA Controller / IDE mode [1039:1183] (rev 03)
00:06.0 PCI bridge [0604]: Silicon Integrated Systems [SiS] PCI-to-PCI bridge [1039:000a]
00:07.0 PCI bridge [0604]: Silicon Integrated Systems [SiS] PCI-to-PCI bridge [1039:000a]
00:0f.0 Audio device [0403]: Silicon Integrated Systems [SiS] Azalia Audio Controller [1039:7502]
00:1f.0 PCI bridge [0604]: Silicon Integrated Systems [SiS] PCI-to-PCI bridge [1039:0004]
01:00.0 VGA compatible controller [0300]: Silicon Integrated Systems [SiS] 771/671 PCIE VGA Display Adapter [1039:6351] (rev 10)
02:00.0 Ethernet controller [0200]: Atheros Communications, Inc. AR5006EG 802.11 b/g Wireless PCI Express Adapter [168c:001c] (rev 01)

$dmesg
[  211.460000] sis190 Gigabit Ethernet driver 1.2 loaded.
[  211.460000] ACPI: PCI Interrupt 0000:00:04.0[A] -> GSI 19 (level, low) -> IRQ 21
[  211.460000] PCI: Setting latency timer of device 0000:00:04.0 to 64
[  211.480000] 0000:00:04.0: Read MAC address from APC.
[  211.480000] 0000:00:04.0: Can not find ISA bridge.
[  211.480000] ACPI: PCI interrupt for device 0000:00:04.0 disabled
[  211.480000] sis190: probe of 0000:00:04.0 failed with error -5

$diff /root/zoz /root/zozPathModified
1c1
< diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c
---
> diff --git sis190.c sis190.c
3,4c3,4
< --- a/drivers/net/sis190.c
< +++ b/drivers/net/sis190.c
---
> --- sis190.c
> +++ sis190.c
Comment 8 M. Emal Alekozai 2008-01-12 17:44:05 UTC
Created attachment 14431 [details]
unmodified copy of 'sis190.c' file from ubuntu 7.10; ubuntu kernel '2.6.22-14-generic'
Comment 9 M. Emal Alekozai 2008-01-18 09:44:58 UTC
The problem with the nic "sis191" is solved [1].
1: https://lists.ubuntu.com/archives/ubuntu-users/2008-January/134789.html

Emal
Comment 10 Juan Jose Pablos 2008-01-18 11:16:11 UTC
Hi,
When this small change is going to be added to the kernel?
I have not been able to find it on a few changelogs.
Comment 11 Francois Romieu 2008-01-18 14:18:16 UTC
juanjo@apertus.es  2008-01-18 11:16:
[...]
> When this small change is going to be added to the kernel?
> I have not been able to find it on a few changelogs.

The patch is in Jeff's upstream branch. It should be included in the
kernel during the post-2.6.24 merge window.

Comment 12 Francois Romieu 2008-01-24 14:21:54 UTC
The patch is included in Linus's tree as ebc71647309539aaf9088f4e41b9f364cce8f7eb.

-- 
Ueimor
Comment 13 dan 2009-09-15 19:53:19 UTC
I am also having the same problem in Archlinux, the 2.6.30 kernel.

Does anyone know how I can fix this problem?
Comment 14 Juan Jose Pablos 2009-09-21 20:22:02 UTC
Bug #11509 seems related to this bug

Note You need to log in before you can comment on or make changes to this bug.