Bug 9414 - Not work light of button-led with module b43 in chipset broadcom 4318
Not work light of button-led with module b43 in chipset broadcom 4318
Status: CLOSED CODE_FIX
Product: Drivers
Classification: Unclassified
Component: network-wireless
All Linux
: P1 low
Assigned To: Rafael J. Wysocki
:
Depends on:
Blocks: 9243
  Show dependency treegraph
 
Reported: 2007-11-19 20:15 UTC by Cristian Aravena Romero
Modified: 2007-12-20 15:49 UTC (History)
5 users (show)

See Also:
Kernel Version: 2.6.24-rc3
Tree: Mainline
Regression: Yes


Attachments
$dmesg (125.18 KB, text/plain)
2007-11-19 20:16 UTC, Cristian Aravena Romero
Details
$lspci -vvn (7.75 KB, text/x-log)
2007-11-19 20:17 UTC, Cristian Aravena Romero
Details
$lspci -vv (9.19 KB, text/x-log)
2007-11-19 20:17 UTC, Cristian Aravena Romero
Details
$lsmod (3.62 KB, text/x-log)
2007-11-19 20:18 UTC, Cristian Aravena Romero
Details
$cat /boot/config-2.6.24-rc3.071118 (80.04 KB, text/plain)
2007-11-19 20:19 UTC, Cristian Aravena Romero
Details
$uname -a (89 bytes, text/x-log)
2007-11-19 20:20 UTC, Cristian Aravena Romero
Details
Test patch (5.75 KB, patch)
2007-12-10 11:27 UTC, Larry Finger
Details | Diff

Description Cristian Aravena Romero 2007-11-19 20:15:19 UTC
Most recent kernel where this bug did not occur: 2.6.23.1
Distribution: Ubuntu Gutsy
Hardware Environment: Compaq Presario V2000
Software Environment: Default + update of kernel
Problem Description: In kernel 2.6.23.1 work with module bcm43xx and work light of led, I update to kernel 2.6.24-rc3 and WiFi work. And light of led not work.
Comment 1 Cristian Aravena Romero 2007-11-19 20:16:43 UTC
Created attachment 13638 [details]
$dmesg
Comment 2 Cristian Aravena Romero 2007-11-19 20:17:15 UTC
Created attachment 13639 [details]
$lspci -vvn
Comment 3 Cristian Aravena Romero 2007-11-19 20:17:41 UTC
Created attachment 13640 [details]
$lspci -vv
Comment 4 Cristian Aravena Romero 2007-11-19 20:18:32 UTC
Created attachment 13641 [details]
$lsmod
Comment 5 Cristian Aravena Romero 2007-11-19 20:19:18 UTC
Created attachment 13642 [details]
$cat /boot/config-2.6.24-rc3.071118
Comment 6 Cristian Aravena Romero 2007-11-19 20:20:06 UTC
Created attachment 13643 [details]
$uname -a
Comment 7 Cristian Aravena Romero 2007-11-24 12:06:15 UTC
Bunk, the driver work. not-light is detail. Not regression +1.
Comment 8 Adrian Bunk 2007-11-24 12:35:02 UTC
Of course a non-working driver would be a much more serious regression than a non-working LED, but still a no longer working LED is a regression.
Comment 9 Michael Buesch 2007-11-24 12:43:40 UTC
Did someone actually try to hook this led up from userspace?
It's all doable through sysfs led triggers.

I mean, I can not magically fix this bug, as I don't own such a device. Some help is required.
Comment 10 Cristian Aravena Romero 2007-11-25 13:25:26 UTC
@Michael: How to I help?
Comment 11 Ingo Molnar 2007-12-04 04:05:04 UTC
Cristian, if 2.6.24-rc4 is still not working for you (most likely), and if you have time to track this down, you could try to figure out the exact commit that causes this regression for you. This is a clear regression, 2.6.23.1 had a working led, 2.6.24-rc does not. So one of the commits inbetween caused this problem for you.

git-bisection can take quite some time though. Here's an link that explains it:

http://kernel.org/pub/software/scm/git/docs/v1.4.4.4/howto/isolate-bugs-with-bisect.txt

here's a quickstart:

git-clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6.git
cd linux-2.6.git
git-bisect start
git-bisect good v2.6.23
git-bisect bad HEAD

then build the kernel that is suggested and boot into it - checking whether the led works fine or not. If the led works then do this:

  git-bisect good

if the led does not work then do this:

  git-bisect bad

repeat this, then after 10-15 rebuilds and reboots [ ouch! :-/ ] you'll finally arrive to a point where git-bisect outputs a "bad commit" message to you. Paste that result into this bugzilla. (also paste the contents of "git-bisect log" so that we can see your bisection results)

you can then quit bisection via:

  git-bisect reset

and can track the latest upstream kernel by doing "git-pull" in the linux-2.6.git directory.
Comment 12 Ingo Molnar 2007-12-04 04:14:34 UTC
> git-bisection can take quite some time though. Here's an link that explains it:
> 
> http://kernel.org/pub/software/scm/git/docs/v1.4.4.4/howto/isolate-bugs-with-bisect.txt

here's another link with git-bisect info:

  http://www.kernel.org/doc/local/git-quick.html

Comment 13 Rafael J. Wysocki 2007-12-07 17:32:13 UTC
Cristian, any progress?
Comment 14 Larry Finger 2007-12-10 11:27:49 UTC
Created attachment 13947 [details]
Test patch

The attached patch should fix the radio LED issue. There is still a locking problem to be solved; however, the patch is suitable for testing.
Comment 15 Rafael J. Wysocki 2007-12-14 16:04:45 UTC
Patch is available: http://marc.info/?l=linux-wireless&m=119763729709783&w=2
Patch (for b43legacy) is available: http://marc.info/?l=linux-wireless&m=119767190601835&w=2
Comment 16 Rafael J. Wysocki 2007-12-20 15:49:23 UTC
Fixed by:

commit 1a8d122782bdabe4475f29d022c9a0c092ac9878
Author: Larry Finger <Larry.Finger@lwfinger.net>
Date:   Fri Dec 14 13:59:11 2007 +0100

    b43: Fix rfkill radio LED

http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=1a8d122782bdabe4475f29d022c9a0c092ac9878

Note You need to log in before you can comment on or make changes to this bug.