Bug 90681 - dm-crypt.c 708 the compiler could delete the 'memset' function call
Summary: dm-crypt.c 708 the compiler could delete the 'memset' function call
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-03 15:40 UTC by Arman
Modified: 2015-01-03 19:32 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.18.1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Arman 2015-01-03 15:40:39 UTC 
The compiler could delete the 'memset' function call, which is used to flush 'buf' buffer. The RtlSecureZeroMemory() function should be used to erase the private data. dm-crypt.c : 708

static int crypt_iv_tcw_whitening(....)
{
...
out:
  memset(buf, 0, sizeof(buf));
  return r;
}
...
Comment 1 Arman 2015-01-03 15:42:55 UTC 
there is no RtlSecureZeroMemory()
Comment 2 George Shuklin 2015-01-03 17:51:12 UTC 
I think the issue is not with alternative name, but the possible missoptimization of the memset call.

And that one is sensitive...
Comment 3 Arman 2015-01-03 19:05:38 UTC 
it's missoptimization : RtlSecureZeroMemory() alternative for linux must be used
Note You need to log in before you can comment on or make changes to this bug.