Bug 8681 - USB printer autosuspend breaks Samsung ML-2510
Summary: USB printer autosuspend breaks Samsung ML-2510
Status: CLOSED PATCH_ALREADY_AVAILABLE
Alias: None
Product: Drivers
Classification: Unclassified
Component: USB (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Greg Kroah-Hartman
URL:
Keywords:
Depends on:
Blocks: USB
  Show dependency tree
 
Reported: 2007-06-26 19:16 UTC by kernel.bugzilla-eran
Modified: 2007-09-16 13:32 UTC (History)
3 users (show)

See Also:
Kernel Version: 2.6.21.5
Subsystem:
Regression: ---
Bisected commit-id:


Attachments
dmesg output (5.76 KB, text/plain)
2007-07-03 15:10 UTC, kernel.bugzilla-eran
Details

Description kernel.bugzilla-eran 2007-06-26 19:16:06 UTC
With all recent kernels, support for the Samsung ML-2510 USB printer (USB ID 04e8:327e) is broken. When plugged in the printer shows up and works for a few seconds; then, with no obvious trigger or dmesg output, it stops working and disappears from `lsusb`. Other USB devices on this system work fine,

I've narrowed it down the following patch, introduced in 2.6.20:

  d0532184086906889f4a0cd92eade1f7be49fbac 
  USB: autosuspend for usb printer driver

  this implements autosuspend for usb printers. It compiles and is tested.

Reverting that single patch from 2.6.21.5 fixes the problem.

Please consider fixing/reverting/quirking the USB printer autosuspend code.
Comment 1 Andrew Morton 2007-06-26 19:28:46 UTC
Subject: Re: [Bugme-new]  New: USB printer autosuspend breaks
 Samsung ML-2510

On Tue, 26 Jun 2007 19:12:14 -0700 (PDT) bugme-daemon@bugzilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=8681
> 
>            Summary: USB printer autosuspend breaks Samsung ML-2510
>            Product: Drivers
>            Version: 2.5
>      KernelVersion: 2.6.21.5
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: USB
>         AssignedTo: greg@kroah.com
>         ReportedBy: kernel.bugzilla-eran@tromer.org
> 
> 
> With all recent kernels, support for the Samsung ML-2510 USB printer (USB ID
> 04e8:327e) is broken. When plugged in the printer shows up and works for a
> few
> seconds; then, with no obvious trigger or dmesg output, it stops working and
> disappears from `lsusb`. Other USB devices on this system work fine,
> 
> I've narrowed it down the following patch, introduced in 2.6.20:
> 
>   d0532184086906889f4a0cd92eade1f7be49fbac 
>   USB: autosuspend for usb printer driver
> 
>   this implements autosuspend for usb printers. It compiles and is tested.
> 
> Reverting that single patch from 2.6.21.5 fixes the problem.
> 
> Please consider fixing/reverting/quirking the USB printer autosuspend code.
> 
> 

Oliver got fingered ;)
Comment 2 Alan Stern 2007-07-03 13:44:56 UTC
Can you build a kernel with CONFIG_USB_DEBUG and attach a dmesg log showing what happens when the printer autosuspend fails?

Also could you attach a usbmon log?  (Directions are in the kernel source file Documentation/usb/usbmon.txt.)
Comment 3 kernel.bugzilla-eran 2007-07-03 15:10:49 UTC
Created attachment 11937 [details]
dmesg output

Attaching dmesg output, on 2.6.22-rc6, of plugging in the printer and running "lsusb" after a few seconds. By the time I ran "lsusb" the printer was no longer visible.

I've posted this earlier to linux-usb-devel@lists.sourceforge.net and here's Oliver reply: http://thread.gmane.org/gmane.linux.usb.devel/55443
Comment 4 Alan Stern 2007-07-04 12:23:17 UTC
Ah yes, I see Oliver did.  Probably the printer has a bug in the way it responds to Device-Status requests.  The bug causes Linux to think the printer isn't working any more.  It's a little surprising, though, that the printer wasn't detected again and re-initialized.
Comment 5 kernel.bugzilla-eran 2007-09-05 08:22:39 UTC
Fixed by in v2.6.23-rc1 by commit e4f747373cd96c86db3c64c21710748c6889c03c ("USB: quirk for samsung printer").

Note You need to log in before you can comment on or make changes to this bug.