Bug 86341 - crypto/caam/caamhash.c:1180]: (error) Memory leak: edesc
Summary: crypto/caam/caamhash.c:1180]: (error) Memory leak: edesc
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 18:32 UTC by David Binderman
Modified: 2014-10-23 15:27 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.17.1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-10-15 18:32:53 UTC 
Source code is

    if (dma_mapping_error(jrdev, state->buf_dma)) {
        dev_err(jrdev, "unable to map src\n");
        return -ENOMEM;
    }

Maybe better code is

    if (dma_mapping_error(jrdev, state->buf_dma)) {
        dev_err(jrdev, "unable to map src\n");
        kfree(edesc);
     
        return -ENOMEM;
    }
Comment 1 Alan 2014-10-23 14:03:59 UTC 
(pinged freescale)
Comment 2 Cristian Stoica 2014-10-23 15:27:56 UTC 
Thanks for reporting. There are several similar issues there.
Note You need to log in before you can comment on or make changes to this bug.