Bug 84351 - sound/soc/fsl/fsl_sai.c:143: shift overflow problems
Summary: sound/soc/fsl/fsl_sai.c:143: shift overflow problems
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Sound(ALSA) (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Jaroslav Kysela
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 20:44 UTC by David Binderman
Modified: 2015-06-11 16:16 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.17-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-09-11 20:44:26 UTC 
sound/soc/fsl/fsl_sai.c:143:7: warning: signed shift result (0x3FC000000) requires 35 bits to represent, but 'int' only has 32 bits [-Wshift-overflow]

    regmap_update_bits(sai->regmap, FSL_SAI_xCR2(tx),
               FSL_SAI_CR2_MSEL_MASK, val_cr2);
Comment 1 Takashi Iwai 2015-06-02 18:16:39 UTC 
Could you elaborate which macro will be expanded to too large?
Comment 2 David Binderman 2015-06-02 19:27:24 UTC 
sound/soc/fsl/fsl_sai.h:#define FSL_SAI_CR2_MSEL_MASK	(0xff << 26)
Comment 3 Takashi Iwai 2015-06-03 12:51:14 UTC 
Thanks, now it's clearer.  I submitted the patch.
Comment 4 Takashi Iwai 2015-06-11 16:16:08 UTC 
The fix was already merged in ASoC tree.
Note You need to log in before you can comment on or make changes to this bug.