Bug 82681 - gpu/drm/radeon/cik.c:1849: bad nested conditions ?
Summary: gpu/drm/radeon/cik.c:1849: bad nested conditions ?
Status: RESOLVED WILL_NOT_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(DRI - non Intel) (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_video-dri
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-18 08:44 UTC by David Binderman
Modified: 2014-08-21 17:03 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.17-rc1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-08-18 08:44:18 UTC 
[linux-3.17-rc1/drivers/gpu/drm/radeon/cik.c:1849] -> [linux-3.17-rc1/drivers/gpu/drm/radeon/cik.c:1850]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

    if (running == 0) {
        if (running) {
Comment 1 David Binderman 2014-08-18 08:46:18 UTC 
Same thing elsewhere

[linux-3.17-rc1/drivers/gpu/drm/radeon/si.c:1564] -> [linux-3.17-rc1/drivers/gpu/drm/radeon/si.c:1565]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.
Comment 2 Alex Deucher 2014-08-21 16:55:03 UTC 
Earlier versions of the code had the core part of the loop split out into a separate function so it needed the additional checks in case it was called from elsewhere.  I left them in as a reminder in case the code is ever restructured.
Note You need to log in before you can comment on or make changes to this bug.