Kernel Bug Tracker – Bug 8205
dev_priv->ring.space not updated in r128_do_cce_reset()?
Last modified: 2009-03-25 17:07:53 UTC
When I checked ATI Rage 128 driver source code, I found that
drm_r128_private_t*->ring->space is a field keeping the size of ring. In file
drivers/char/drm/r128_cce.c, there's a function r128_do_cce_reset():
static void r128_do_cce_reset(drm_r128_private_t * dev_priv)
dev_priv->ring.tail = 0;
In a device reset, the space of the ring should be zero, and this information
might need to be updated into dev_priv->ring.tail. Even if this is not
necessary, it will make the program easier for others to understand.
Steps to reproduce:
I found this place with the help of a source-analysis tool.