Bug 80521 - media/davinci_vpfe/dm365_ipipeif.c:210: poor error testing ?
Summary: media/davinci_vpfe/dm365_ipipeif.c:210: poor error testing ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Staging (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_staging@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 14:50 UTC by David Binderman
Modified: 2014-07-17 16:32 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 14:50:54 UTC 
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]: (style) Checking if unsigned variable 'val' is less than zero.

    val = get_oneshot_mode(ipipeif->input);
    if (val < 0) {
        pr_err("ipipeif: links setup required");
        return -EINVAL;
    }

but

static int get_oneshot_mode(enum ipipeif_input_entity input)
Comment 1 Andrey Utkin 2014-07-17 16:32:04 UTC 
Thanks. https://patchwork.kernel.org/patch/4577091/
Note You need to log in before you can comment on or make changes to this bug.