Bug 80501 - comedi/drivers/addi-data/hwdrv_apci3200.c: 3 * pointless test ?
Summary: comedi/drivers/addi-data/hwdrv_apci3200.c: 3 * pointless test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Staging (show other bugs)
Hardware: All Linux
: P1 low
Assignee: drivers_staging@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 14:40 UTC by David Binderman
Modified: 2014-07-17 16:31 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 14:40:36 UTC 
1.

[linux-3.16-rc5/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c:1814]: (style) Checking if unsigned variable 'ui_ChannelNo' is less than zero.

       if (ui_ChannelNo < 0 || ui_ChannelNo > 15) {

2.

[linux-3.16-rc5/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c:1821]: (style) Checking if unsigned variable 'ui_ChannelNo' is less than zero.
[linux-3.16-rc5/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c:1827]: (style) Checking if unsigned variable 'ui_ChannelNo' is less than zero.

Duplicates.
Comment 1 Andrey Utkin 2014-07-17 16:31:12 UTC 
Thanks. https://patchwork.kernel.org/patch/4577121/
Note You need to log in before you can comment on or make changes to this bug.