Bug 80481 - drivers/net/wireless/ath/ath9k/spectral.c: 4 * pointless test ?
Summary: drivers/net/wireless/ath/ath9k/spectral.c: 4 * pointless test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: network-wireless (show other bugs)
Hardware: All Linux
: P1 low
Assignee: drivers_network-wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 12:54 UTC by David Binderman
Modified: 2014-07-17 14:05 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.15-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 12:54:38 UTC 
1.

[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:316]: (style) Checking if unsigned variable 'val' is less than zero.

Source code is

    if (val < 0 || val > 1)
        return -EINVAL;

2.

[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:364]: (style) Checking if unsigned variable 'val' is less than zero.
[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:412]: (style) Checking if unsigned variable 'val' is less than zero.
[linux-3.16-rc5/drivers/net/wireless/ath/ath9k/spectral.c:460]: (style) Checking if unsigned variable 'val' is less than zero.

Duplicates.
Comment 1 Andrey Utkin 2014-07-17 14:05:08 UTC 
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575591/
Note You need to log in before you can comment on or make changes to this bug.