Bug 80461 - misc/sgi-gru/grukdump.c:199: pointless code ?
Summary: misc/sgi-gru/grukdump.c:199: pointless code ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 low
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 12:48 UTC by David Binderman
Modified: 2014-07-17 14:05 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc5
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-17 12:48:29 UTC 
[linux-3.16-rc5/drivers/misc/sgi-gru/grukdump.c:199]: (style) Checking if unsigned variable 'gid' is less than zero.

    if (req.gid >= gru_max_gids || req.gid < 0)
        return -EINVAL;
Comment 1 Andrey Utkin 2014-07-17 14:05:48 UTC 
Thanks, patch submitted: https://patchwork.kernel.org/patch/4575581/
Note You need to log in before you can comment on or make changes to this bug.