Bug 79871 - comedi/drivers/ni_atmio16d.c: 2 * possible cut'n'paste errors ?
Summary: comedi/drivers/ni_atmio16d.c: 2 * possible cut'n'paste errors ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Staging (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_staging@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 13:11 UTC by David Binderman
Modified: 2014-07-11 09:04 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-10 13:11:44 UTC 
1.

[linux-3.16-rc4/drivers/staging/comedi/drivers/ni_atmio16d.c:341]: (style) Expression is always false because 'else if' condition matches previous condition at line 338.

    } else if (cmd->convert_arg <= 0xffffffff /* 6553600000 */) {
        base_clock = CLOCK_10_KHZ;
        timer = cmd->convert_arg / 100000;
    } else if (cmd->convert_arg <= 0xffffffff /* 65536000000 */) {

2.

[linux-3.16-rc4/drivers/staging/comedi/drivers/ni_atmio16d.c:409]: (style) Expression is always false because 'else if' condition matches previous condition at line 406.

        } else if (cmd->scan_begin_arg < 0xffffffff /* 6553600000 */) {
            base_clock = CLOCK_10_KHZ;
            timer = cmd->scan_begin_arg / 100000;
        } else if (cmd->scan_begin_arg < 0xffffffff /* 65536000000 */) {
Note You need to log in before you can comment on or make changes to this bug.