Bug 79821 - ethernet/freescale/gianfar_ethtool.c:1584: possible bad expression ?
Summary: ethernet/freescale/gianfar_ethtool.c:1584: possible bad expression ?
Status: NEW
Alias: None
Product: Networking
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Stephen Hemminger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 11:25 UTC by David Binderman
Modified: 2015-02-05 10:49 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-10 11:25:44 UTC 
[linux-3.16-rc4/drivers/net/ethernet/freescale/gianfar_ethtool.c:1584]: (style) Same expression on both sides of '|'.

    for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl);
Comment 1 sanjeevsharma 2015-01-12 07:01:37 UTC 
Hello Stephen,

IMO the correct expression should be as below.

for (; (i < MAX_FILER_IDX - 1) && ( i < tab->fe[i].ctrl);
Comment 2 sanjeevsharma 2015-02-05 10:49:26 UTC 
Hello,

Patch has been accepted and Now I can mark this Resolved Fixed.

https://lkml.org/lkml/2015/2/4/705
Note You need to log in before you can comment on or make changes to this bug.