Bug 79811 - ethernet/dec/tulip/tulip_core.c:592: array index check in wrong place ?
Summary: ethernet/dec/tulip/tulip_core.c:592: array index check in wrong place ?
Status: NEW
Alias: None
Product: Networking
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Stephen Hemminger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 11:21 UTC by David Binderman
Modified: 2014-07-10 11:21 UTC (History)
0 users

See Also:
Kernel Version: 3.16-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-10 11:21:17 UTC 
ethernet/dec/tulip/tulip_core.c:592]: (style) Array index 'j' is used before limits check.

            for (j = 0; buf[j] != 0xee && j < 1600; j++)

Suggest put limit check before index use.
Note You need to log in before you can comment on or make changes to this bug.