Bug 79801 - pvrusb2/pvrusb2-v4l2.c:956: possible bad if test ?
Summary: pvrusb2/pvrusb2-v4l2.c:956: possible bad if test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: USB (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Greg Kroah-Hartman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 11:06 UTC by David Binderman
Modified: 2014-07-10 14:38 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-10 11:06:50 UTC 
[linux-3.16-rc4/drivers/media/usb/pvrusb2/pvrusb2-v4l2.c:956]: (style) Expression is always false because 'else if' condition matches previous condition at line 952.

       if (pvrusb2_debug & PVR2_TRACE_V4LIOCTL) {
            pvr2_trace(PVR2_TRACE_V4LIOCTL,
                   "pvr2_v4l2_do_ioctl failure, ret=%ld", ret);
        } else {
            if (pvrusb2_debug & PVR2_TRACE_V4LIOCTL) {

Suggest code rework.
Comment 1 Andrey Utkin 2014-07-10 12:33:43 UTC 
Submitted a patch: https://patchwork.kernel.org/patch/4523401/
Thanks for report.
Comment 2 Greg Kroah-Hartman 2014-07-10 14:34:41 UTC 
On Thu, Jul 10, 2014 at 11:06:50AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=79801
> 
>             Bug ID: 79801
>            Summary: pvrusb2/pvrusb2-v4l2.c:956: possible bad if test ?

Please send this to the people identified with the
scripts/get_maintainer.pl tool for this file.
Comment 3 Andrey Utkin 2014-07-10 14:38:55 UTC 
(In reply to Greg Kroah-Hartman from comment #2)
> Please send this to the people identified with the
> scripts/get_maintainer.pl tool for this file.

I did.

To: linux-kernel@vger.kernel.org,
 linux-media@vger.kernel.org
Cc: m.chehab@samsung.com,
 isely@pobox.com,
 dcb314@hotmail.com.
Note You need to log in before you can comment on or make changes to this bug.