Bug 79781 - mach-s3c24xx/mach-osiris-dvs.c:81: possible bad test ?
Summary: mach-s3c24xx/mach-osiris-dvs.c:81: possible bad test ?
Status: NEW
Alias: None
Product: Platform Specific/Hardware
Classification: Unclassified
Component: ARM (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: linux-arm-kernel@lists.arm.linux.org.uk
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 09:06 UTC by David Binderman
Modified: 2014-07-10 12:48 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-07-10 09:06:31 UTC 
[linux-3.16-rc4/arch/arm/mach-s3c24xx/mach-osiris-dvs.c:81]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

        if (!old_dvs & new_dvs ||
            !cur_dvs & new_dvs) {

Maybe someone got & and && muxed up. Suggest code rework.

[linux-3.16-rc4/arch/arm/mach-s3c24xx/mach-osiris-dvs.c:82]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Duplicate.
Comment 1 Andrey Utkin 2014-07-10 12:48:30 UTC 
Submitted a patch: https://patchwork.kernel.org/patch/4523481/
Thanks for report.
Note You need to log in before you can comment on or make changes to this bug.