Bug 78061 - tty/vt/vt.c: 4 * leap before look problems ?
Summary: tty/vt/vt.c: 4 * leap before look problems ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 09:22 UTC by David Binderman
Modified: 2014-06-16 09:22 UTC (History)
0 users

See Also:
Kernel Version: 3.16-rc1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-06-16 09:22:14 UTC 
[linux-3.16-rc1/drivers/tty/vt/vt.c:1363]: (style) Array index 'i' is used before limits check.
[linux-3.16-rc1/drivers/tty/vt/vt.c:1368]: (style) Array index 'i' is used before limits check.
[linux-3.16-rc1/drivers/tty/vt/vt.c:1384]: (style) Array index 'i' is used before limits check.
[linux-3.16-rc1/drivers/tty/vt/vt.c:1389]: (style) Array index 'i' is used before limits check.

First one is

               if (vc->vc_par[i] == 5 &&  /* 256 colours */
                    i < vc->vc_npar) {     /* ubiquitous */

Suggest code rework.
Note You need to log in before you can comment on or make changes to this bug.