Bug 78041 - staging/rtl8192ee/base.c:830: bad if test ?
Summary: staging/rtl8192ee/base.c:830: bad if test ?
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Staging (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_staging@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-16 09:12 UTC by David Binderman
Modified: 2014-07-04 23:43 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.16-rc1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2014-06-16 09:12:16 UTC 
[linux-3.16-rc1/drivers/staging/rtl8192ee/base.c:830]: (style) Expression '(X & 0xc) != 0xc0' is always true.

Source code is

    if ((get_rf_type(rtlphy) == RF_2T2R) &&
        (map & 0x000c) != 0x000c0) {

Suggest code rework.
Comment 1 Andrey Utkin 2014-07-04 23:43:51 UTC 
Posted a patch: https://patchwork.kernel.org/patch/4486051/
Thank you for report.
Note You need to log in before you can comment on or make changes to this bug.