Bug 767 - in ieee1394 file iso.c fails to compile
Summary: in ieee1394 file iso.c fails to compile
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: IEEE1394 (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Ben Collins
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-02 15:05 UTC by Leslie Donaldson
Modified: 2003-07-03 05:11 UTC (History)
0 users

See Also:
Kernel Version: 2.5.70
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description Leslie Donaldson 2003-06-02 15:05:26 UTC
Distribution:redhat
Hardware Environment:Alpha PC164LX
Software Environment:Rawhide

Problem Description:

file fails to compile (as module embedded untested)
drivers/ieee1394/iso.c: In function `hpsb_iso_xmit_sync':
drivers/ieee1394/iso.c:355: arithmetic on pointer to an incomplete type
drivers/ieee1394/iso.c:355: warning: implicit declaration of function
`set_current_state'
drivers/ieee1394/iso.c:355: `TASK_INTERRUPTIBLE' undeclared (first use in this
function)
drivers/ieee1394/iso.c:355: (Each undeclared identifier is reported only once
drivers/ieee1394/iso.c:355: for each function it appears in.)
drivers/ieee1394/iso.c:355: warning: implicit declaration of function
`signal_pending'
drivers/ieee1394/iso.c:355: arithmetic on pointer to an incomplete type
drivers/ieee1394/iso.c:355: warning: implicit declaration of function `schedule'
drivers/ieee1394/iso.c:355: arithmetic on pointer to an incomplete type
drivers/ieee1394/iso.c:355: dereferencing pointer to incomplete type
drivers/ieee1394/iso.c:355: `TASK_RUNNING' undeclared (first use in this function)
drivers/ieee1394/iso.c: In function `hpsb_iso_wake':
drivers/ieee1394/iso.c:431: `TASK_INTERRUPTIBLE' undeclared (first use in this
function)
make[2]: *** [drivers/ieee1394/iso.o] Error 1
make[1]: *** [drivers/ieee1394] Error 2
make: *** [drivers] Error 2

Steps to reproduce:

Select ieee1394 as an module and activate all items lower in the configuration
tree as an module

Solution

Add the line

#include <linux/sched.h>

between the following lines (line number 11)

#include <linux/slab.h>
#include "iso.h"
Comment 1 Ben Collins 2003-06-02 16:03:58 UTC
Fixed in linux1394 SVN repo as revision 946. A patch including the fix has been sent to Linus.

Thanks for the report.

Note You need to log in before you can comment on or make changes to this bug.