Bug 75751 - Public header lirc.h misplaced in kernel source instead of kernel-headers
Summary: Public header lirc.h misplaced in kernel source instead of kernel-headers
Status: RESOLVED CODE_FIX
Alias: None
Product: v4l-dvb
Classification: Unclassified
Component: v4l-other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: v4l-other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-08 18:56 UTC by Alec Leamas
Modified: 2016-04-26 17:24 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.12.7-300.fc20.
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Move lirc.h to uapi/ (14.15 KB, patch)
2014-12-15 10:50 UTC, Alec Leamas
Details | Diff
device manpage sketch, shows header symbol usage. (1.31 KB, application/x-troff-man)
2014-12-15 10:52 UTC, Alec Leamas
Details
ioctl manpage sketch, shows symbol usage. (7.82 KB, text/plain)
2014-12-15 10:53 UTC, Alec Leamas
Details
Move internal lirc.h to public uapi/ (second try). (14.04 KB, patch)
2014-12-15 11:06 UTC, Alec Leamas
Details | Diff

Description Alec Leamas 2014-05-08 18:56:08 UTC
This is about current file source/include/media/lirc.h.

This file really describes a public interface. Specifically, when coding lirc user-space drivers the definitions here are necessary to code/encode the data to/from the kernel. Mostly, this applies to the /dev/lircX devices.

Thus this file ought to be moved to the kernel-headers package (sorry, I'm a kernel rookie, no details...)
Comment 1 Alan 2014-05-19 10:59:47 UTC
Yes - some of this does appear to belong in include/uapi
Comment 2 Alec Leamas 2014-12-15 10:48:19 UTC
Hm... I guess since lirc is the only user of this interface right now we need to do something to get this rolling (?).

Attaching a patch. This moves the complete lirc.h to uapi.
Comment 3 Alec Leamas 2014-12-15 10:50:47 UTC
Created attachment 160631 [details]
Move lirc.h to uapi/

Please be gentle, I'm a kernel rookie.
Comment 4 Alec Leamas 2014-12-15 10:52:34 UTC
Created attachment 160641 [details]
device manpage sketch, shows header symbol usage.
Comment 5 Alec Leamas 2014-12-15 10:53:48 UTC
Created attachment 160651 [details]
ioctl manpage sketch, shows symbol usage.
Comment 6 Alec Leamas 2014-12-15 11:06:00 UTC
Created attachment 160661 [details]
Move internal lirc.h to public uapi/ (second try).
Comment 7 Alec Leamas 2014-12-16 13:12:34 UTC
There is also some kernel docs referring to these symbols at  https://www.kernel.org/doc/htmldocs/media_api/lirc_dev.htm
Comment 8 Alec Leamas 2015-12-06 09:41:24 UTC
Patch is tracked in https://patchwork.linuxtv.org/patch/31865/
Comment 9 Alec Leamas 2016-04-26 17:24:30 UTC
Merged in kernel since long: 
https://github.com/torvalds/linux/commit/b7be755733dc44c72956c91876e5d86c56052a54

Closing.

Note You need to log in before you can comment on or make changes to this bug.