Bug 73511 - Invalid arguments passed to audit_log_string() routine resulting in embedded spaces in op= values
Summary: Invalid arguments passed to audit_log_string() routine resulting in embedded ...
Status: NEW
Alias: None
Product: Other
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: other_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-04 04:52 UTC by Burn Alting
Modified: 2014-04-08 22:50 UTC (History)
1 user (show)

See Also:
Kernel Version: torvalds/linux.git (collected 3 Apr 2014)
Subsystem:
Regression: No
Bisected commit-id:

Attachments
This is a diff -Npru of a cleanly pulled torvalds/linux.git on 3 Apr 2014 and a copy of same with my modifications (2.18 KB, text/plain)
2014-04-04 04:52 UTC, Burn Alting 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Burn Alting 2014-04-04 04:52:32 UTC 
Created attachment 131411 [details]
This is a diff -Npru of a cleanly pulled torvalds/linux.git on 3 Apr 2014 and a copy of same with my modifications

Various audit events dealing with adding, removing and updating rules result in invalid values set for the op keys which result in embedded spaces in op= values.
The invalid values are
op="add rule"       set in kernel/auditfilter.c
op="remove rule"    set in kernel/auditfilter.c
op="remove rule"    set in kernel/audit_tree.c
op="updated rules"  set in kernel/audit_watch.c
op="remove rule"    set in kernel/audit_watch.c

The attached patch replaces the space in the above values with an underscore character ('_').

Regards
Burn Alting
Comment 1 Alan 2014-04-08 09:54:34 UTC 
Please see Documentation/SubmittingPatches

We don't accept patches via Bugzilla, as we need a Signed-off-by trail and discussion.
Comment 2 Burn Alting 2014-04-08 22:50:22 UTC 
(In reply to Alan from comment #1)
> Please see Documentation/SubmittingPatches
> 
> We don't accept patches via Bugzilla, as we need a Signed-off-by trail and
> discussion.

The patch will be formally submitted by Richard Guy Briggs <rgb@redhat.com>.
Note You need to log in before you can comment on or make changes to this bug.