Bug 72921 - toshiba_acpi has a wrong special keys for Toshiba Kirabook
Summary: toshiba_acpi has a wrong special keys for Toshiba Kirabook
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Platform_x86 (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: drivers_platform_x86@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-25 04:10 UTC by Marco Antonio Konopacki
Modified: 2014-04-08 10:32 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.13.0-17
Subsystem:
Regression: No
Bisected commit-id:


Attachments
My dmesg dump (78.07 KB, text/plain)
2014-03-25 04:10 UTC, Marco Antonio Konopacki
Details

Description Marco Antonio Konopacki 2014-03-25 04:10:56 UTC
Created attachment 130611 [details]
My dmesg dump

Toshiba Kirabook has a wrong special keys table at toshiba_acpi module. I have a suggest to a correct table bellow:

#toshiba_acpi.c line 153 - from linux-source 3.11.0

static const struct key_entry toshiba_acpi_keymap[] = {
        { KE_KEY, 0x158, { KEY_RFKILL } },
        { KE_KEY, 0x101, { KEY_MUTE } },
        { KE_KEY, 0x102, { KEY_ZOOMOUT } },
        { KE_KEY, 0x103, { KEY_ZOOMIN } },
        { KE_KEY, 0x12c, { KEY_KBDILLUMTOGGLE } },
        { KE_KEY, 0x139, { KEY_ZOOMRESET } },
        { KE_KEY, 0x13b, { KEY_COFFEE } },
        { KE_KEY, 0x13c, { KEY_BATTERY } },
        { KE_KEY, 0x13e, { KEY_SWITCHVIDEOMODE } },
        { KE_KEY, 0x13c, { KEY_BRIGHTNESSDOWN } },
        { KE_KEY, 0x13d, { KEY_BRIGHTNESSUP } },
        { KE_KEY, 0x142, { KEY_WLAN } },
        { KE_KEY, 0x13f, { KEY_TOUCHPAD_TOGGLE } },
        { KE_KEY, 0x17f, { KEY_FN } },
        { KE_KEY, 0xb05, { KEY_PROG2 } },
        { KE_KEY, 0xb06, { KEY_WWW } },
        { KE_KEY, 0xb07, { KEY_MAIL } },
        { KE_KEY, 0xb30, { KEY_STOP } },
        { KE_KEY, 0xb31, { KEY_PREVIOUSSONG } },
        { KE_KEY, 0xb32, { KEY_NEXTSONG } },
        { KE_KEY, 0xb33, { KEY_PLAYPAUSE } },
        { KE_KEY, 0xb5a, { KEY_MEDIA } },
        { KE_IGNORE, 0x1430, { KEY_RESERVED } },
        { KE_END, 0 },
};
Comment 1 Lan Tianyu 2014-03-25 04:49:45 UTC
toshiba_acpi is a platform driver and so reassign to platfom/x86 category.
Comment 2 Alan 2014-04-08 10:32:30 UTC
Please also see Documentation/SubmittingPatches on how t submit your changes upstream

Note You need to log in before you can comment on or make changes to this bug.