Bug 72451 - Missing IS_ENABLED could cause array out of bounds access
Summary: Missing IS_ENABLED could cause array out of bounds access
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: Alan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-18 15:00 UTC by Fernando Muñoz
Modified: 2014-03-20 12:05 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.13.6
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Fernando Muñoz 2014-03-18 15:00:03 UTC 
I believe the following cases should be put inside #if IS_ENABLED(CONFIG_DMA_ENGINE_RAID)

https://github.com/torvalds/linux/blob/master/drivers/dma/dmaengine.c#L984-L989

Otherwise when CONFIG_DMA_ENGINE_RAID config is not enabled, unmap_pool will only have one element.

Identified by Cppcheck

$ cppcheck ./linux-3.13.6/drivers/dma/dmaengine.c -f
Checking linux-3.13.6/drivers/dma/dmaengine.c...
[linux-3.13.6/drivers/dma/dmaengine.c:932]: (error) Array 'unmap_pool[1]' accessed at index 2, which is out of bounds.
[linux-3.13.6/drivers/dma/dmaengine.c:934]: (error) Array 'unmap_pool[1]' accessed at index 3, which is out of bounds.
Note You need to log in before you can comment on or make changes to this bug.