Bug 72101 - Uninitialized variable in intel_sdvo.c
Summary: Uninitialized variable in intel_sdvo.c
Status: RESOLVED INVALID
Alias: None
Product: Drivers
Classification: Unclassified
Component: Video(DRI - Intel) (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: intel-gfx-bugs@lists.freedesktop.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-14 17:55 UTC by Han Shen
Modified: 2014-03-20 16:58 UTC (History)
3 users (show)

See Also:
Kernel Version: 3.4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Han Shen 2014-03-14 17:55:51 UTC 
At function intel_sdvo_dpms@intel_sdvo.c, input1 and input2 may not be initialized.

These 2 variables are expected to be setup in intel_sdvo_get_trained_inputs, which in some cases may have an early return , leaving input1 and input2 not properly setup.
Comment 1 Jani Nikula 2014-03-20 12:51:12 UTC 
intel_sdvo_get_trained_inputs() returns false on early return when input1 and input2 have not been initialized, and we check the return status before touching the variables.
Comment 2 Han Shen 2014-03-20 16:58:30 UTC 
Hmm. Yeah, you'are right. Then it is the compiler bug, I'll fire one for gcc.
Note You need to log in before you can comment on or make changes to this bug.