Bug 72061 - [Regression, bisected 9e30cc] "sysfs, kernfs: no need to kern_mount() sysfs from sysfs_init()" prevents system from booting correctly
Summary: [Regression, bisected 9e30cc] "sysfs, kernfs: no need to kern_mount() sysfs f...
Status: RESOLVED CODE_FIX
Alias: None
Product: File System
Classification: Unclassified
Component: SysFS (show other bugs)
Hardware: All Linux
: P1 blocking
Assignee: Greg Kroah-Hartman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-14 03:38 UTC by Alexandre Demers
Modified: 2014-04-18 02:58 UTC (History)
3 users (show)

See Also:
Kernel Version: 3.14-rc6
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Alexandre Demers 2014-03-14 03:38:52 UTC
I've been struggling with something that looks like a bug, but I may be wrong. Since 3.14-rc1, I can't boot my system correctly. The kernel will boot, but when it comes to mounting the disk's partition, the computer seem to hit something while mounting the root partition: the light associated to the disk's activity stays on; if I hit ctrl+alt+del in the first 10 to 15 seconds, the computer will restart; beyond that point, the system just continues to work on the disk for a long period (I was painting a door the other day and it continued reading or writing the whole time) until it begins outputting errors. I'll have to add it in another comment later. It is about not being able to copy because disk is full (my partitions have plenty of free space). So I've been bisecting until I found out when the problem had begun.

------
Bisecting points to the following first bad commit:
9e30cc9595303b27b48be49b7bcd4d0679e34253 is the first bad commit
commit 9e30cc9595303b27b48be49b7bcd4d0679e34253
Author: Tejun Heo <tj@kernel.org>
Date:   Thu Nov 28 14:54:38 2013 -0500

    sysfs, kernfs: no need to kern_mount() sysfs from sysfs_init()
    
    It has been very long since sysfs depended on vfs to keep track of
    internal states and whether sysfs is mounted or not doesn't make any
    difference to sysfs's internal operation.
    
    In addition to init and filesystem type registration, sysfs_init()
    invokes kern_mount() to create in-kernel mount of sysfs.  This
    internal mounting doesn't server any purpose anymore.  Remove it.
    
    Signed-off-by: Tejun Heo <tj@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

:040000 040000 d85991e8a4e333ad651dc593cacff5e6b8d4f916 d3bd9c50967807c9145a7bd9d3ec7978101c93f3 M	fs
------

Using any kernel compiled before that commit boots fine. Am I missing something?
Comment 1 Greg Kroah-Hartman 2014-03-14 04:28:58 UTC
On Fri, Mar 14, 2014 at 03:38:52AM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:

Please email this to the people on the patch and the
linux-kernel@vger.kernel.org mailing list so that they can properly
respond.
Comment 2 Alex 2014-04-02 04:55:57 UTC
Reproduced today as well on Arch Linux x64 + KDE
Comment 3 Alexandre Demers 2014-04-02 05:03:21 UTC
Aliaksandr, just to let you know, a patch is already on its way for 3.15. It may be backported to 3.14.X (TBD). I'm now working in creating a qemu environment to reproduce it to narrow down why kern_mount() is still expected and by what  program.

There is an ongoing discussion about it on the linux-kernel@vger.kernel.org.
Comment 4 Alex 2014-04-02 15:22:38 UTC
Alexandre, thanks for sharing! I already applied patch and have kernel working, so it is not a urgent issue. Also, if I can help in figuring out the cause of issue, please let me know - I will do my best to help.
Comment 5 Alexandre Demers 2014-04-18 02:58:29 UTC
Commit "Revert "sysfs, driver-core: remove unused {sysfs|device}_schedule_callback_owner()"" pushed in 3.15 and backported in 3.14 branch.

Note You need to log in before you can comment on or make changes to this bug.