Bug 7152 - khvcd not stopped during suspend
Summary: khvcd not stopped during suspend
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Serial (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Benjamin Herrenschmidt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-13 03:26 UTC by Michael Tautschnig
Modified: 2007-04-28 12:49 UTC (History)
2 users (show)

See Also:
Kernel Version: 2.6.18-rc6, 2.6.17.10
Tree: Mainline
Regression: ---


Attachments
hvc_console-suspend-fix (524 bytes, text/x-patch)
2006-09-13 19:03 UTC, Andrew Morton
Details

Description Michael Tautschnig 2006-09-13 03:26:10 UTC
Most recent kernel where this bug did not occur: ?
Distribution: Debian
Hardware Environment: PowerBook6,8
Software Environment: ?
Problem Description:

Enabling
CONFIG_HVC_DRIVER=y
CONFIG_HVC_RTAS=y
Makes suspend-to-disk (using hibernate) not work anymore due to khvcd not stopping:

kernel: Stopping tasks: ============================================================
kernel: stopping tasks timed out after 20 seconds (1 tasks remaining):
kernel: khvcd
kernel: Restarting tasks...<6> Strange, khvcd not stopped
kernel: done


Steps to reproduce: Enable CONFIG_HVC_RTAS and try to suspend; Usually, people
probably won't use CONFIG_HVC_RTAS together on a system they suspend, but Debian
has added it to their default powerpc config.
Comment 1 Russell King 2006-09-13 03:30:58 UTC
What's a khvcd?

Comment 2 Michael Tautschnig 2006-09-13 04:19:48 UTC
I suppose it's the kernel HVC daemon ... Serial might be the wrong component,
but I didn't know where it fits.

It's defined in drivers/char/hvc_console.c, maybe this helps.
Comment 3 Andrew Morton 2006-09-13 18:58:46 UTC
Uh, OK, I cheerfully dinged benh with this - I'll send it along
to Mike Ellerman and Ryan Arnold.
Comment 4 Andrew Morton 2006-09-13 19:03:08 UTC
Created attachment 9017 [details]
hvc_console-suspend-fix

Actually even I might be able to fix this.

Can you please test this patch?
Comment 5 Andrew Morton 2006-09-13 19:07:24 UTC
Thanks.  But please, use email next time?
Comment 6 Michael Tautschnig 2006-09-14 14:49:01 UTC
Thanks, this patch did the trick!

BTW, Andrew: Was it me you asked to use email next time? This might be a very
stupid question, but which address was I supposed to use?

Thanks again,
Michael
Comment 7 Andrew Morton 2006-09-14 15:12:51 UTC
On Thu, 14 Sep 2006 14:58:09 -0700
bugme-daemon@bugzilla.kernel.org wrote:

> Thanks, this patch did the trick!

good-o, thanks.

> BTW, Andrew: Was it me you asked to use email next time? This might be a very
> stupid question, but which address was I supposed to use?

err, that comment was supposed to be against a different bugzilla report
(someone tried to submit a patch via bugzilla).  Blame it on senility.

Comment 8 Adrian Bunk 2006-12-02 09:57:05 UTC
The patch from this bug was included in 2.6.18.

Note You need to log in before you can comment on or make changes to this bug.