Bug 70081 - mutex_unlock is missed in function (drm_crtc_init) in file (linux-3.13/drivers/gpu/drm/drm_crtc.c)
Summary: mutex_unlock is missed in function (drm_crtc_init) in file (linux-3.13/driver...
Status: RESOLVED INVALID
Alias: None
Product: Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: drivers_other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 17:23 UTC by Ahmed Tamrawi
Modified: 2014-02-07 11:24 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.13
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ahmed Tamrawi 2014-02-05 17:23:00 UTC 
In function (drm_crtc_init) in file (linux-3.13/drivers/gpu/drm/drm_crtc.c):

The structure (crtc->mutex) gets successfully locked at line (636) by (drm_modeset_lock_all(dev)), but it is not unlocked before line (637) where the structure is reinitialized. After line (637) the re-initialized structure gets locked at (638) and unlocked at line (650) by (drm_modeset_unlock_all(dev)).

A possible solution is to call (drm_modeset_unlock_all(dev)) before the re-initialization line (637).
Comment 1 Alan 2014-02-07 11:24:26 UTC 
Intentional
Note You need to log in before you can comment on or make changes to this bug.