Bug 69881 - rts5208/sd.c:3515: bad expression
Summary: rts5208/sd.c:3515: bad expression
Status: NEW
Alias: None
Product: Drivers
Classification: Unclassified
Component: Staging (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_staging@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-03 11:54 UTC by David Binderman
Modified: 2018-05-29 00:51 UTC (History)
3 users (show)

See Also:
Kernel Version: 3.14-rc1
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description David Binderman 2014-02-03 11:54:11 UTC
[linux-3.14-rc1/drivers/staging/rts5208/sd.c:3515]: (style) Expression '(X & 0x1e) != 0x3' is always true.

Source code is

                if ((ptr[3] & 0x1E) != 0x03)
                    TRACE_RET(chip, STATUS_FAIL);
Comment 1 Levente Kurusa 2014-02-15 09:33:24 UTC
Thank you!
Posting as a patch, adding your:

Reported-by: David Binderman <dcb314@hotmail.com>

--
Levente Kurusa
Comment 2 David Binderman 2014-08-21 16:59:50 UTC
Still broken some six months later in 3.17-rc1.

Did your patch get accepted ?
Comment 3 Hugo Lefeuvre 2018-05-29 00:51:40 UTC
Fixed in 58930cced012adb01bc78b3687049b17ef44d0a3.

Note You need to log in before you can comment on or make changes to this bug.