Bug 69581 - warning during resume from s3 - regression 3.8.13 -> 3.9.0
Summary: warning during resume from s3 - regression 3.8.13 -> 3.9.0
Status: RESOLVED CODE_FIX
Alias: None
Product: v4l-dvb
Classification: Unclassified
Component: saa7134 (show other bugs)
Hardware: i386 Linux
: P1 normal
Assignee: v4l-dvb_saa7134@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-28 14:51 UTC by Valerio Vanni
Modified: 2014-04-14 10:24 UTC (History)
7 users (show)

See Also:
Kernel Version: 3.9.0 and later
Subsystem:
Regression: Yes
Bisected commit-id:


Attachments
logs and configs (152.78 KB, text/plain)
2014-01-28 15:02 UTC, Valerio Vanni
Details
logs with 3.12.8 on squeeze (12.31 KB, text/plain)
2014-01-29 22:26 UTC, Valerio Vanni
Details
logs with 3.12.9 on squeeze (11.99 KB, text/plain)
2014-01-29 23:51 UTC, Valerio Vanni
Details
logs 3.12.9 on Lenny (84.12 KB, text/plain)
2014-01-31 02:43 UTC, Valerio Vanni
Details
Might fix the suspend issue (556 bytes, patch)
2014-03-04 10:03 UTC, Hans Verkuil
Details | Diff

Description Valerio Vanni 2014-01-28 14:51:30 UTC
[1.] One line summary of the problem:    

Kernel 3.12.8 gives a warning during resume from S3 sleep

[2.] Full description of the problem/report:

It happens also with 3.12.7, 3.12.6 and 3.13. It doesn't happen with 2.6.24.7.
OS is Debian Lenny, with vanilla kernel. It happens the same after upgrade to Squeeze.

I suspend the machine with s2ram and it goes off.
During the resume it writes that warning, then it seem to work normally, 
except for serial redirection of console.

I use redirection of console to serial port (with lilo directive: append="
console=ttyS0 console=tty0") and I check the messages in another machine.
This stops working as soon as I suspend. It begins to send mangled lines and 
it doesn't work again until the next full restart.
Only the serial redirection has this problem, the local console  works.

I put some log as attachment.
Comment 1 Valerio Vanni 2014-01-28 15:02:48 UTC
Created attachment 123641 [details]
logs and configs
Comment 2 Alan 2014-01-29 14:59:24 UTC
Workqueue: events_unbound async_run_entry_fn
 00000000 00000000 c13464e1 c103cd80 c102d8fd 00000009 ec835e00 f53861a4
 f806f0d0 f5386024 c102d91d 00000009 00000000 c103cd80 ffffffff 01000286
 c1036322 00000286 ec835da4 f5970000 f5970000 c1036358 0003e8e4 c134663f
Call Trace:
 [<c13464e1>] ? dump_stack+0x3e/0x55
 [<c103cd80>] ? __request_module+0x34/0x1ac
 [<c102d8fd>] ? warn_slowpath_common+0x66/0x7a
 [<c102d91d>] ? warn_slowpath_null+0xc/0xf
 [<c103cd80>] ? __request_module+0x34/0x1ac
 [<c1036322>] ? try_to_del_timer_sync+0x3a/0x41
 [<c1036358>] ? del_timer_sync+0x2f/0x39
 [<c134663f>] ? schedule_timeout+0x147/0x15d
 [<c10363a2>] ? del_timer+0x40/0x40
 [<f806e370>] ? v4l2_i2c_new_subdev_board+0x23/0xa7 [v4l2_common]
 [<f806e43d>] ? v4l2_i2c_new_subdev+0x49/0x51 [v4l2_common]
 [<f82d690b>] ? saa7134_board_init2+0x869/0xb58 [saa7134]
 [<c1036322>] ? try_to_del_timer_sync+0x3a/0x41
 [<c1036358>] ? del_timer_sync+0x2f/0x39
 [<c134663f>] ? schedule_timeout+0x147/0x15d
 [<c1030003>] ? SyS_setitimer+0x11/0x9e
 [<f82d7ca7>] ? saa7134_resume+0xbf/0x150 [saa7134]
Comment 3 Valerio Vanni 2014-01-29 22:26:56 UTC
Created attachment 123841 [details]
logs with 3.12.8 on squeeze

I've just tried with kernel 3.12.9 and the problem remains (only the "i915" part has gone, and I reported it in the proper bug).
Also this time the log encases the entire process of suspending and resuming.
Comment 4 Valerio Vanni 2014-01-29 22:56:08 UTC
Comment on attachment 123841 [details]
logs with 3.12.8 on squeeze

Sorry, I sent this as a "3.12.9", but it was a "3.12.8" (the difference from that at the start of the thread is simply an upgrade from lenny to sqeeze")
Comment 5 Valerio Vanni 2014-01-29 23:51:09 UTC
Created attachment 123851 [details]
logs with 3.12.9 on squeeze

This is 3.12.9 on squeeze, later I'll try also 3.12.9 on Lenny.
Comment 6 Valerio Vanni 2014-01-31 02:43:09 UTC
Created attachment 123931 [details]
logs 3.12.9 on Lenny

I've tried with kernel 3.12.9 and the crash is still there.
I put here the logs, from boot to suspend and resume.

I've also tried with 3.13 drm-intel-nightly: it keeps crashing but the "i915" warning does not show anymore. It remains the "saa7134".
Comment 7 Valerio Vanni 2014-02-07 07:55:49 UTC
It still happens with 3.12.10.
Comment 8 Valerio Vanni 2014-02-08 01:56:23 UTC
It still happens with 3.13.2.
Comment 9 Valerio Vanni 2014-02-12 20:35:25 UTC
I tried with 3.2.54, and the crash doesn't happens.
It seem that the regression is somewhere between 3.2.54 and 3.12.6.
Comment 10 Valerio Vanni 2014-02-12 22:30:40 UTC
I tested many kernels and I found the point of regression.
3.8.13 is the last that works
3.9.1 is the first that fails
Comment 11 Valerio Vanni 2014-02-13 00:47:39 UTC
3.9.0 is the first that fails
Comment 12 Hans Verkuil 2014-03-04 10:03:22 UTC
Created attachment 127981 [details]
Might fix the suspend issue

Try this patch, see if it solves the problem.
Comment 13 Valerio Vanni 2014-03-04 22:35:03 UTC
I've tried on 3.13.5 kernel: it solves.
Comment 14 Hans Verkuil 2014-03-05 09:25:53 UTC
Thanks for testing, I'll prepare a proper patch and make sure it gets into 3.14 (3.15 at the latest).
Comment 15 Valerio Vanni 2014-03-27 12:33:25 UTC
I saw the message on linux-media, but so far the patch is not in 3.14 nor in linux-next.
Will it be backported, later, also to older kernels? (3.13, 3.12 etc)
Comment 16 Hans Verkuil 2014-03-27 13:06:00 UTC
I've asked Mauro what happened to them. They are in the 'fixes' queue, but none of them are pushed to the mainline. So this might be postponed until one of the 3.14 stable versions. This particular patch should eventually be applied for 3.9 upwards.
Comment 17 Valerio Vanni 2014-03-31 00:48:24 UTC
Testing the new saa7134 driver against this bug
https://bugzilla.kernel.org/show_bug.cgi?id=73031
I've found that it gots the suspend/resume issue. The only difference is that the new driver warns only during the first suspend/resume cycle, the old does at every.

It seems only to miss the patch, if I appy it the issue disappears.
Comment 18 Hans Verkuil 2014-04-14 08:07:36 UTC
This patch is now merged in the mainline, so this bug report can be closed.

I don't seem to be able to assign this bug report to myself, so I can't change the status.

Mauro, can you assign it to me so I can close it? I assume you have the permissions to do that.
Comment 19 Valerio Vanni 2014-04-14 10:24:14 UTC
I close it.

Note You need to log in before you can comment on or make changes to this bug.