Static analyser cppcheck says [linux-3.13/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c:270]: (style) A pointer can not be negative so it is either pointless or an error to check if it is. Source code is ipipe_mode = get_ipipe_mode(ipipe); if (ipipe < 0) { pr_err("Failed to get ipipe mode"); return -EINVAL; } I suspect ipipe_mode = get_ipipe_mode(ipipe); if (ipipe_mode < 0) { pr_err("Failed to get ipipe mode"); return -EINVAL; } might be better code.
Patch posted, see https://patchwork.kernel.org/patch/4486101/ Please look if that is clean for checker now.