Bug 69031 - moxa: TX descriptor length bits not cleared between sends
Summary: moxa: TX descriptor length bits not cleared between sends
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: Network (show other bugs)
Hardware: ARM Linux
: P1 high
Assignee: drivers_network@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-20 10:21 UTC by Jonas Jensen
Modified: 2014-10-06 07:17 UTC (History)
0 users

See Also:
Kernel Version: 3.12-rc1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jonas Jensen 2014-01-20 10:21:50 UTC 
TX_DESC1_BUF_SIZE_MASK is not added to bits that are cleared, before the TX buffer length is set. 

Failing to do so can cause the controller to drop dead i.e. all TX interrupts stop, resulting in complete communication failure.
Comment 1 Jonas Jensen 2014-10-06 07:17:00 UTC 
Fixed in v3.17-rc5.

See commit "net: moxa: clear DESC1 on ndo_start_xmit()" b853f31940c84cce6a3f5cb4f529b029906ee69c.
Note You need to log in before you can comment on or make changes to this bug.