Bug 67621 - BOOT_BIOS fails after Linux-2.6.29
Summary: BOOT_BIOS fails after Linux-2.6.29
Status: NEEDINFO
Alias: None
Product: Platform Specific/Hardware
Classification: Unclassified
Component: i386 (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: platform_i386
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-24 07:34 UTC by Dimon
Modified: 2014-05-13 02:13 UTC (History)
7 users (show)

See Also:
Kernel Version: 3.10.15
Subsystem:
Regression: Yes
Bisected commit-id:

Attachments
config of kernel 3.10.15 (67.76 KB, application/octet-stream)
2013-12-24 07:34 UTC, Dimon 		Details
dmesg (10.12 KB, text/plain)
2013-12-24 07:37 UTC, Dimon 		Details
dmidecode (6.53 KB, text/plain)
2013-12-24 07:38 UTC, Dimon 		Details
patch (8.42 KB, patch)
2013-12-24 07:41 UTC, Dimon 		Details | Diff
patch (8.12 KB, patch)
2013-12-25 05:09 UTC, Dimon 		Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Dimon 2013-12-24 07:34:26 UTC 
Created attachment 119451 [details]
config of kernel 3.10.15

Laptop HP Compaq nx6110 hangs on restart. Test for linux version 3.10.15, 3.10.24 and 3.12.5.
Normally works with kernel-2.6.29.3 
Not tested with other kernels.

reboot=acpi,reboot=efi,reboot=bios,reboot=triple,reboot=pci in kernel parameters does not works too

restart works correctly if the "bios_reboot" code of linux-3.10.15 replaced with "bios_reboot" code from linux-2.6.29.3
Comment 1 Dimon 2013-12-24 07:37:41 UTC 
Created attachment 119461 [details]
dmesg

Dmesg 3.10.15 kernel
Comment 2 Dimon 2013-12-24 07:38:50 UTC 
Created attachment 119471 [details]
dmidecode
Comment 3 Dimon 2013-12-24 07:41:48 UTC 
Created attachment 119481 [details]
patch

this patch adds "bios_reboot" (renamed to "old_reboot") from kernel 2.6.29.3 to 3.10.15, and change default reboot type for HP Compaq laptops to old_reboot
Comment 4 Lan Tianyu 2013-12-25 02:59:36 UTC 
hi, could you send the patch in the comment3 to acpi and x86 maillist?
Comment 5 Dimon 2013-12-25 05:09:30 UTC 
Created attachment 119561 [details]
patch

Its new patch. Find some errors in old patch.
Comment 6 Dimon 2013-12-25 05:10:53 UTC 
(In reply to Lan Tianyu from comment #4)
> hi, could you send the patch in the comment3 to acpi and x86 maillist?

Sorry, but I don't know how to do it. Im a newbie here.
Comment 7 Lan Tianyu 2013-12-25 05:44:05 UTC 
Please follow this link to send the patch.

http://linux.koolsolutions.com/2011/02/26/howto-create-and-submit-your-first-linux-kernel-patch/
Comment 8 mozilla 2014-02-18 17:30:19 UTC 
The reboot on this type of machine appears to work in kernel 3.2, but not in 3.9.  Might help when producing a solution.
Comment 9 Len Brown 2014-03-25 00:15:14 UTC 
> restart works correctly if the "bios_reboot"
> code of linux-3.10.15 replaced with "bios_reboot" code from linux-2.6.29.3

Can you can git bisect which change broke bios_reboot?

http://git-scm.com/docs/git-bisect
Comment 10 Rafael J. Wysocki 2014-04-30 21:23:40 UTC 
Also please check 3.15-rc3, there have been some changes related to reboot recently.
Comment 11 H. Peter Anvin 2014-04-30 21:35:45 UTC 
The old code and the new code are very, very similar, making this hard to guess what might be wrong.  You could try to change:

bios:
        ljmpw   $0xf000, $0xfff0

... to ...

bios:
        ljmpw   $0xffff, $0x0000

... in arch/x86/realmode/rm/reboot.S ...

... to see if that matters.
Comment 12 Dimon 2014-05-13 02:13:07 UTC 
(In reply to Rafael J. Wysocki from comment #10)
> Also please check 3.15-rc3, there have been some changes related to reboot
> recently.

====================================

(In reply to H. Peter Anvin from comment #11)
> The old code and the new code are very, very similar, making this hard to
> guess what might be wrong.  You could try to change:
> 
> bios:
>         ljmpw   $0xf000, $0xfff0
> 
> ... to ...
> 
> bios:
>         ljmpw   $0xffff, $0x0000
> 
> ... in arch/x86/realmode/rm/reboot.S ...
> 
> ... to see if that matters.

I have no more this laptop. Its not my.
Note You need to log in before you can comment on or make changes to this bug.