Bug 67091 - scsi/be2iscsi/be_main.c:328: possible bad if expression ?
Summary: scsi/be2iscsi/be_main.c:328: possible bad if expression ?
Status: NEW
Alias: None
Product: SCSI Drivers
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: scsi_drivers-other
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-12-16 09:51 UTC by David Binderman
Modified: 2013-12-18 14:24 UTC (History)
1 user (show)

See Also:
Kernel Version: 3.13-rc4
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2013-12-16 09:51:01 UTC 
Source code is

        if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
            continue;

Suggest code rework. Bug found by static analyser cppcheck.

[linux-3.13-rc4/drivers/scsi/be2iscsi/be_main.c:328]: (style) Same expression on both sides of '!='.
Note You need to log in before you can comment on or make changes to this bug.