Bug 62081 - ipc/sem.c: wait for simple ops for the proc interface
Summary: ipc/sem.c: wait for simple ops for the proc interface
Status: RESOLVED CODE_FIX
Alias: None
Product: Other
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: other_other
URL: http://marc.info/?l=linux-kernel&m=13...
Keywords:
Depends on: 61351
Blocks: 62061
  Show dependency tree
 
Reported: 2013-09-25 08:01 UTC by Manfred Spraul
Modified: 2013-10-02 07:19 UTC (History)
0 users

See Also:
Kernel Version:
Subsystem:
Regression: No
Bisected commit-id:


Attachments
Patch (1.37 KB, patch)
2013-09-25 15:28 UTC, Manfred Spraul
Details | Diff

Description Manfred Spraul 2013-09-25 08:01:05 UTC
The proc interface calls ipc_lock() directly - thus the exclusion of simple semop's is missing with sysvipc_sem_proc_show().


A "sem_wait_array()" should be added as the first line into sysvipc_sem_proc_show().

It's a correctness thing:
Nothing breaks if get_semotime() is called in parallel with simple ops.
Comment 1 Manfred Spraul 2013-09-25 08:01:45 UTC
Update dependencies: sem_wait_array() does not exist yet in Linus' tree.
Comment 2 Manfred Spraul 2013-09-25 15:28:31 UTC
Created attachment 109631 [details]
Patch
Comment 3 Manfred Spraul 2013-09-25 15:29:00 UTC
patch sent to lkml
Comment 4 Manfred Spraul 2013-10-02 07:19:27 UTC
Fixed

d8c633766ad88527f25d9f81a5c2f083d78a2b39 ipc/sem.c: synchronize the proc interface

Note You need to log in before you can comment on or make changes to this bug.