Bug 6145 - kernel.suid_dumpable sysctl is really fs.suid_dumpable
Summary: kernel.suid_dumpable sysctl is really fs.suid_dumpable
Status: CLOSED CODE_FIX
Alias: None
Product: Process Management
Classification: Unclassified
Component: Other (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Diego Calleja
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-01 08:45 UTC by Sergey Vlasov
Modified: 2006-08-28 06:40 UTC (History)
0 users

See Also:
Kernel Version: 2.6.14, 2.6.16-rc5
Subsystem:
Regression: ---
Bisected commit-id:


Attachments

Description Sergey Vlasov 2006-03-01 08:45:19 UTC
The sysctl option to enable core dumps for suid processes is described in
Documentation/sysctl/kernel.txt as kernel.suid_dumpable; however, it does not work:

$ /sbin/sysctl kernel.suid_dumpable
error: "kernel.suid_dumpable" is an unknown key
$ cat /proc/sys/kernel/suid_dumpable
cat: /proc/sys/kernel/suid_dumpable: No such file or directory

Source inspection has shown that the option was really placed under "fs":

$ /sbin/sysctl fs.suid_dumpable
fs.suid_dumpable = 0
$ cat /proc/sys/fs/suid_dumpable
0

However, both the documentation and include/linux/sysctl.h imply that the option
was intented to be placed under "kernel" (the numeric ID is named
KERN_SETUID_DUMPABLE).

How this should be fixed?  Should the sysctl option be moved from "fs" to
"kernel" (to agree with the documentation), or should the documentation and
numeric ID be changed to match the current implementation?
Comment 1 Andrew Morton 2006-03-01 12:52:42 UTC
We'd need to fix the documentation.  mail me a patch ;)
Comment 2 Alexey Dobriyan 2006-08-27 21:51:31 UTC
Fixed in mainline.

Note You need to log in before you can comment on or make changes to this bug.