Bug 58471 - brcmsmac no longer has conectivity
Summary: brcmsmac no longer has conectivity
Status: CLOSED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: network-wireless (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: drivers_network-wireless@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-18 14:08 UTC by Mike Lothian
Modified: 2013-11-13 20:23 UTC (History)
6 users (show)

See Also:
Kernel Version: 3.10-rc1
Subsystem:
Regression: Yes
Bisected commit-id:


Attachments
Broken dmesg (52.95 KB, text/plain)
2013-05-18 14:08 UTC, Mike Lothian
Details
Working dmesg (48.70 KB, text/plain)
2013-05-18 14:08 UTC, Mike Lothian
Details
brcmsmac: disable power saving (1.71 KB, patch)
2013-05-28 19:59 UTC, Hauke Mehrtens
Details | Diff

Description Mike Lothian 2013-05-18 14:08:12 UTC
Created attachment 101901 [details]
Broken dmesg

Since commit [6da3b6c48d79da96a36c2632053cf4f53bf48fb2] brcmsmac: remove brcms_bss_cfg->associated 

My wireless no longer has any connectivity - it appears connected but pinging google.com doesn't work and websites no longer connect

I've attached my before and after dmesg's and I'll see if I can revert that patch

If it makes any difference the brcmsmac used to spam my logs with lots of errors - but it did work
Comment 1 Mike Lothian 2013-05-18 14:08:57 UTC
Created attachment 101911 [details]
Working dmesg
Comment 2 Mike Lothian 2013-05-18 14:15:36 UTC
And this is the device: 02:00.0 Network controller [0280]: Broadcom Corporation BCM43224 802.11a/b/g/n [14e4:4353] (rev 01)
Comment 3 Mike Lothian 2013-05-26 23:58:18 UTC
Still present in rc2 and rc3 is due out soon - has anyone else been able to confirm this?
Comment 4 Hauke Mehrtens 2013-05-28 19:59:24 UTC
Created attachment 102741 [details]
brcmsmac: disable power saving
Comment 5 Hauke Mehrtens 2013-05-28 20:02:05 UTC
Could you please test the following patch.

There was also a discussion about this problem on the mailing list:
http://permalink.gmane.org/gmane.linux.kernel.wireless.general/108251
Comment 6 Mike Lothian 2013-05-28 23:33:00 UTC
Double whammy - I now have connectivity and my dmesg is no longer being spammed :D
Comment 7 Mike Lothian 2013-06-03 22:18:59 UTC
Are we any closer to getting a solution merged?
Comment 8 paragw 2013-06-27 01:34:17 UTC
Still not working with today's mainline build and git log seems to say the patch wasn't merged. What's the hold up with getting the patch merged?
Comment 9 John W. Linville 2013-06-27 11:40:00 UTC
Not sure where you are looking, it's in Linus's tree:

commit 541e667e1c0f31a7e11d909eb831cf476814a201
Author: Arend van Spriel <arend@broadcom.com>
Date:   Thu Jun 6 13:29:56 2013 +0200

    brcmsmac: disable power-save related functions
    
    This patch fixes a regression introduced by:
    
      commit 6da3b6c48d79da96a36c2632053cf4f53bf48fb2
      Author: Hauke Mehrtens <hauke@hauke-m.de>
      Date:   Sun Mar 24 01:45:52 2013 +0100
    
          brcmsmac: remove brcms_bss_cfg->associated
    
    The regression behaviour was described on mailing list.
    
    http://mid.gmane.org/5197DC4F.7030503@broadcom.com:
    "On laptop I installed kernel with brcmsmac compiled as
    module. It comes up and associates during boot, but after
    logging in there is no connectivity. Triggering reassoc
    gives connectivity for some time, but after a while (1-2 min)
    it stops."
    
    Before the mentioned commit the return value of
    the function brcms_c_ps_allowed() was always false,
    which is desired behaviour as power-save is not
    supported at the moment. Therefor, the function is
    changed to just return false instead of simply
    reverting the mentioned commit.
    
    Bug: 58471 <https://bugzilla.kernel.org/show_bug.cgi?id=58471>
    
    Signed-off-by: Arend van Spriel <arend@broadcom.com>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>
Comment 10 paragw 2013-06-27 13:43:51 UTC
I did a git log drivers/net/wireless/brcm80211/brcmsmac/main.c and it didn't show the commit. Turns out my tree wasn't updated for some reason.

I didn't bother to look carefully because the Ubuntu daily kernel build from yesterday was also having the same connectivity issue described in this bug - it associates but there is no connectivity and reassoc does briefly  will investigate further - may be the Ubuntu folks are also missing the patch or this is a different issue with same symptoms.

Thanks.
Comment 11 paragw 2013-06-27 13:57:23 UTC
Up until yesterday Ubuntu daily mainline builds didn't work - but today's build does seem to fix the issue - which is strange as the patch that fixed it seemed to have been there since Jun 6.

In any case - thank you for the patch and merge - I will finally go back to a fully working 3.10 kernel!

Note You need to log in before you can comment on or make changes to this bug.