Bug 55961 - PATCH: Disable write buffering on Toshiba ToPIC95
Summary: PATCH: Disable write buffering on Toshiba ToPIC95
Status: RESOLVED CODE_FIX
Alias: None
Product: Drivers
Classification: Unclassified
Component: PCMCIA (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: linux-pcmcia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-30 02:19 UTC by Ryan Underwood
Modified: 2016-01-21 00:51 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.8.4
Tree: Mainline
Regression: No


Attachments
Disable write buffering on ToPIC95 if it is left enabled (1.52 KB, patch)
2013-03-30 02:19 UTC, Ryan Underwood
Details | Diff
add revision check (1.55 KB, patch)
2013-04-01 04:16 UTC, Ryan Underwood
Details | Diff

Description Ryan Underwood 2013-03-30 02:19:03 UTC
Created attachment 96651 [details]
Disable write buffering on ToPIC95 if it is left enabled

Attached is a patch that will disable write buffering on the Toshiba ToPIC95 if it is enabled by somebody (it is not supposed to be a power-on default according to the datasheet).  On the ToPIC95, practically no 32-bit Cardbus card will work under heavy load without locking up the whole system if this is left enabled.  I tried about a dozen.  It does not affect 16-bit cards.  This is similar to the O2 bugs in early controller revisions it seems.
Comment 1 Ryan Underwood 2013-03-30 02:19:47 UTC
Tecra 500CDT last BIOS from 1999 is one example of a BIOS which enables this "feature".
Comment 2 Ryan Underwood 2013-04-01 04:16:20 UTC
Created attachment 96881 [details]
add revision check
Comment 3 Ryan Underwood 2013-04-01 04:16:28 UTC
While I don't see any examples of a different-rev ToPIC95 in the wild, I figured it would be a good idea to constrain it to the revision which is known (by me) to have the issues, as well as revisions below that.
Comment 4 Levente Kurusa 2013-11-15 18:46:15 UTC
Hi, 

Please send patches to linux-kernel@vger.kernel.org

We can't do anything with them from bugzilla.
Comment 5 Ryan Underwood 2015-01-30 05:19:20 UTC
I got around to posting a better version of the patch here:
http://lists.infradead.org/pipermail/linux-pcmcia/2015-January/008449.html
Comment 6 Wolfram Sang 2016-01-21 00:51:39 UTC
Commited as 2fb22a8042fe96b4220843f79241c116d90922c4

Note You need to log in before you can comment on or make changes to this bug.