Bug 5492 - pegasus: get_registers never wakes up
Summary: pegasus: get_registers never wakes up
Alias: None
Product: Drivers
Classification: Unclassified
Component: USB (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: Greg Kroah-Hartman
Depends on:
Blocks: USB
  Show dependency tree
Reported: 2005-10-24 21:59 UTC by Herbert Xu
Modified: 2006-03-07 11:15 UTC (History)
0 users

See Also:
Kernel Version: 2.6.14-rc5
Tree: Mainline
Regression: ---


Description Herbert Xu 2005-10-24 21:59:50 UTC
The pegasus get_registers function which is invoked by things such as MII
operations and EEPROM reads may lock because

1) The callback may not be invoked in case of hardware error.
2) The callback does not check the return status of update_regs_eth_async.

For 1) it should impose a timeout just like usb_control_msg.  For 2) it should
check the return status and take the appropriate action (such as waking up the
sleeping process).
Comment 1 Greg Kroah-Hartman 2005-11-14 21:24:39 UTC
Care to propose a patch for this?
Comment 2 Greg Kroah-Hartman 2006-03-06 10:28:20 UTC
No response in 4 months, closing.  If this is still a problem, please reopen
with the requested information.
Comment 3 Herbert Xu 2006-03-06 12:27:33 UTC
Hmm, just because I don't have time to write a patch it doesn't mean that this
bug doesn't exist.  Please only close this bug when it's fixed.  Thanks.
Comment 4 Greg Kroah-Hartman 2006-03-07 11:15:28 UTC
Well, as I do not have this device, nor do I know exactly what the change
should look like, and I'm neither the author or maintainer of this driver,
it's going to be a _very_ long time before I get the time to be able to
write a patch to fix this.

So I'm closing this for now, and if you want to get this fixed, I suggest that
you contact the author and maintainer of this driver.


Note You need to log in before you can comment on or make changes to this bug.