Bug 54781 - graphic driver doesn't support brightness changes and can't resume from suspend
Summary: graphic driver doesn't support brightness changes and can't resume from suspend
Status: ASSIGNED
Alias: None
Product: Drivers
Classification: Unclassified
Component: Platform_x86 (show other bugs)
Hardware: x86-64 Linux
: P1 normal
Assignee: drivers_platform_x86@kernel-bugs.osdl.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-04 18:45 UTC by Petr Bena
Modified: 2016-11-10 10:34 UTC (History)
5 users (show)

See Also:
Kernel Version: 3.8.1
Subsystem:
Regression: No
Bisected commit-id:


Attachments

Description Petr Bena 2013-03-04 18:45:59 UTC
asus x201e

integrated intel hd graphics

driver doesn't resume from suspend and it's not possible to change the brightness using any console commands, neither the buttons (only before boot).

petanb@petrbena:/var/log$ lspci | grep VGA
00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller (rev 09)
petanb@petrbena:/var/log$ 
petanb@petrbena:/var/log$ uname -a
Linux petrbena 3.8.1-custom #2 SMP Sat Mar 2 23:28:01 CET 2013 x86_64 x86_64 x86_64 GNU/Linux

older kernels don't work either, I tried appending acpi_osi=Linux acpi_backlight=vendor to grub
Comment 1 Daniel Vetter 2013-03-04 19:12:59 UTC
Can you please check whether any of the backlight drivers in /sys/class/backlight do anything interesting? Please also list all the drivers your system has.
Comment 2 Petr Bena 2013-03-04 21:16:49 UTC
hello, can you please tell me how can I check that? bellow is list of drivers loaded in kernel

petanb@petrbena:~$ sudo lsmod
[sudo] password for petanb: 
Module                  Size  Used by
michael_mic            12612  8 
arc4                   12573  4 
snd_hda_codec_hdmi     36804  1 
snd_hda_codec_realtek    78387  1 
snd_hda_intel          43730  3 
snd_hda_codec         140030  3 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_intel
i915                  604229  5 
snd_hwdep              13563  1 snd_hda_codec
snd_seq_midi           13324  0 
coretemp               13399  0 
drm_kms_helper         49196  1 i915
snd_rawmidi            30570  1 snd_seq_midi
drm                   281320  6 i915,drm_kms_helper
snd_seq_midi_event     14899  1 snd_seq_midi
joydev                 17377  0 
alx                    68002  0 
kvm_intel             136728  0 
asus_nb_wmi            12854  0 
asus_wmi               24225  1 asus_nb_wmi
compat                 13227  1 alx
mdio                   13807  1 alx
snd_seq                61554  2 snd_seq_midi,snd_seq_midi_event
kvm                   443065  1 kvm_intel
psmouse                86341  0 
sparse_keymap          13890  1 asus_wmi
wmi                    19070  1 asus_wmi
lib80211_crypt_tkip    17336  0 
snd_seq_device         14497  3 snd_seq_midi,snd_rawmidi,snd_seq
snd_pcm                97486  3 snd_hda_codec_hdmi,snd_hda_intel,snd_hda_codec
serio_raw              13215  0 
snd_timer              29532  2 snd_seq,snd_pcm
wl                   3074904  0 
evbug                  12661  0 
ghash_clmulni_intel    13259  0 
mac_hid                13205  0 
pcspkr                 12718  0 
i2c_algo_bit           13413  1 i915
snd                    78958  16 snd_hda_codec_hdmi,snd_hda_codec_realtek,snd_hda_intel,snd_hda_codec,snd_hwdep,snd_rawmidi,snd_seq,snd_seq_device,snd_pcm,snd_timer
mei                    41215  0 
soundcore              15047  1 snd
rfcomm                 42651  0 
cryptd                 20360  1 ghash_clmulni_intel
video                  19152  2 i915,asus_wmi
cfg80211              520338  1 wl
bnep                   18181  2 
i2c_i801               21793  0 
snd_page_alloc         18710  2 snd_hda_intel,snd_pcm
bluetooth             228856  10 rfcomm,bnep
lpc_ich                17061  0 
lib80211               14381  2 lib80211_crypt_tkip,wl
lp                     17759  0 
microcode              22893  0 
parport                46354  1 lp
binfmt_misc            17431  1 
nls_iso8859_1          12713  1 
nls_cp437              16991  1 
vfat                   17461  1 
fat                    61346  1 vfat
raid10                 48130  0 
raid456                65923  0 
async_pq               13142  1 raid456
async_xor              12806  2 raid456,async_pq
xor                    17116  1 async_xor
async_memcpy           12529  1 raid456
async_raid6_recov      12824  1 raid456
raid6_pq               97812  2 async_pq,async_raid6_recov
async_tx               13349  5 raid456,async_pq,async_xor,async_memcpy,async_raid6_recov
raid1                  35269  0 
raid0                  17188  0 
multipath              13145  0 
linear                 12894  0 
btrfs                 803429  1 
zlib_deflate           26914  1 btrfs
libcrc32c              12644  1 btrfs
Comment 3 Petr Bena 2013-03-04 21:20:04 UTC
I figured out that submitting a different value to one of drivers actually change the brightness:

root@petrbena:/home/petanb# echo 3882 > /sys/class/backlight/intel_backlight/brightness 

there are two of them

lrwxrwxrwx 1 root root 0 Mar  4 22:13 asus-nb-wmi -> ../../devices/platform/asus-nb-wmi/backlight/asus-nb-wmi
lrwxrwxrwx 1 root root 0 Mar  4 22:15 intel_backlight -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-LVDS-1/intel_backlight

for some reason my system is likely using the other one, might be a conflict with asus-nb-wmi driver?
Comment 4 Petr Bena 2013-03-04 21:49:32 UTC
ok after disabling asus one the brightness now works, however the resume from suspend is still not ok.

I found a workaround and that is after resume, close lid, open lid and graphic wake up. However this should work without having to do this.
Comment 5 Petr Bena 2013-03-04 21:52:43 UTC
also after 1 successful suspend it stop working with:

Mar  4 22:50:49 petrbena kernel: [  331.736305] PM: Device 0000:03:00.0 failed to suspend async: error -5

so it's not able to suspend. I tried this with multiple reboots and always after 1 successful suspend it stop working
Comment 6 Daniel Vetter 2013-03-04 22:53:59 UTC
Ok, this is a bug with the asus wmi driver, it should not register a defunct backlight control. You can work around with in your xorg.conf with the backlight option (pls check the intel manpage).

Reassigning to acpi, though I wouldn't put much hope - the asus wmi seems to be pretty unmaintained :(
Comment 7 Aaron Lu 2013-04-22 09:01:58 UTC
Hi Daniel,
asus wmi driver belongs to platform-drivers-x86, not acpi. So I'll move it there.

Hi Petr,
For the "PM: Device 0000:03:00.0 failed to suspend async: error -5" issue, please identify which driver handles this device and then you can file a separate bug report for that driver.
Comment 8 Petr Bena 2013-04-22 09:06:40 UTC
regarding suspend:

I already sorted this out - the problem was in wl driver (the wi-fi driver, which is actually open source, but for some reason not implemented in kernel, so it needs to be installed as 3rd / proprietary driver).

I am unloading this driver before suspending, so it works now to me. Seems to be problem with wl, not a kernel.

Regarding brightness, it still doesn't work - eg. the keys which are supposed to change the brightness do not respond and there are 2 backlight controls in /sys/class one is defunct and one is OK
Comment 9 Petr Bena 2013-04-22 09:09:00 UTC
note that I am running:

petanb@petrbena:~/Downloads$ uname -a
Linux petrbena 3.8.1-custom #2 SMP Sat Mar 2 23:28:01 CET 2013 x86_64 x86_64 x86_64 GNU/Linux

which is older version of kernel - I didn't update because I didn't see any change in changelog that might be affecting this issue, which is actually the only issue I have right now, kernel side
Comment 10 Petr Bena 2013-04-22 09:11:38 UTC
also there is another problem I found out when resuming from suspend and I forgot to mention: when I resume from suspend the backlight is turned off (the screen is working and displaying some image, which is just hard to see as there is no backlight at all). The only workaround I found is close the laptop lid and open it again, which turn on the backlight, though it lock the screen and trigger some lid-close events
Comment 11 Szőgyényi Gábor 2016-11-09 19:36:26 UTC
Please try this bug with latest kernel image.
Comment 12 Petr Bena 2016-11-10 10:33:38 UTC
I don't have this laptop anymore
Comment 13 Petr Bena 2016-11-10 10:34:22 UTC
You can probably close this now although the problem may not have been fixed, I can't do that as I use different bugzilla account now

Note You need to log in before you can comment on or make changes to this bug.