Bug 54051 - Expand Dell OptiPlex 760 reboot quirk
Summary: Expand Dell OptiPlex 760 reboot quirk
Status: CLOSED INSUFFICIENT_DATA
Alias: None
Product: ACPI
Classification: Unclassified
Component: BIOS (show other bugs)
Hardware: i386 Linux
: P1 normal
Assignee: Aaron Lu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-18 14:38 UTC by Pascal de Bruijn
Modified: 2013-10-09 02:27 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.4.32
Tree: Mainline
Regression: No


Attachments
[PATCH] x86: Expand Dell OptiPlex 760 reboot quirk (1.06 KB, patch)
2013-02-18 14:46 UTC, Pascal de Bruijn
Details | Diff
[PATCH 1/2] x86: Expand Dell OptiPlex 760 reboot quirk (1.33 KB, patch)
2013-04-08 09:09 UTC, Pascal de Bruijn
Details | Diff
[PATCH 2/2] x86: add Dell OptiPlex 780 reboot quirk (1.14 KB, patch)
2013-04-08 09:10 UTC, Pascal de Bruijn
Details | Diff
[PATCH 1/3] x86: Expand Dell OptiPlex 760 reboot quirk (1.33 KB, patch)
2013-09-05 06:49 UTC, Pascal de Bruijn
Details | Diff
[PATCH 2/3] x86: add Dell OptiPlex 780 reboot quirk (1.14 KB, patch)
2013-09-05 06:49 UTC, Pascal de Bruijn
Details | Diff
[PATCH 3/3] x86: add Dell OptiPlex 755 reboot quirk (1.13 KB, patch)
2013-09-05 06:50 UTC, Pascal de Bruijn
Details | Diff

Description Pascal de Bruijn 2013-02-18 14:38:40 UTC
Currently the kernel has a reboot quick for the Dell OptiPlex 760 system, where three bios properties are matched. However the DMI_BOARD_NAME match (against "0G919G") only applies the quirk in a very specific case.

We've recently run into this failure to reboot issue on a series of Dell OptiPlex 760 systems with another DMI_BOARD_NAME.
Comment 1 Pascal de Bruijn 2013-02-18 14:46:44 UTC
Created attachment 93501 [details]
[PATCH] x86: Expand Dell OptiPlex 760 reboot quirk

After patching a custom built 3.4.32 kernel, we found that our particular OptiPlex 760 systems are properly rebooting (as they were previously not).
Comment 2 Pascal de Bruijn 2013-02-18 14:50:53 UTC
Some previous related history:
https://bugs.launchpad.net/linux/+bug/488319
Comment 3 Aaron Lu 2013-02-21 05:08:15 UTC
Hi Pascal,

Thanks for the report and the patch. I would suggest you send the patch to the LKML mailing list so that people will give you comments or merge your code.
The maintainer should be "H. Peter Anvin" <hpa@zytor.com>.
Comment 4 Aaron Lu 2013-03-13 08:13:47 UTC
Patch sent but no comments yet.

https://lkml.org/lkml/2013/2/21/66
Comment 5 Pascal de Bruijn 2013-04-08 09:09:18 UTC
Created attachment 97671 [details]
[PATCH 1/2] x86: Expand Dell OptiPlex 760 reboot quirk


Slightly updated patch which also changes the comment accordingly.
Comment 6 Pascal de Bruijn 2013-04-08 09:10:02 UTC
Created attachment 97681 [details]
[PATCH 2/2] x86: add Dell OptiPlex 780 reboot quirk

The OptiPlex 780 has the same reboot issue.
Comment 7 Aaron Lu 2013-06-09 02:42:37 UTC
So we have two patches to solve two issues, right?

Please submit them upstream, so that maintainers will be able to take them, thanks. Please re-send after a while if there is no response from maintainer.
Comment 8 Aaron Lu 2013-07-01 02:51:30 UTC
What's the status of this patch?
Comment 9 Pascal de Bruijn 2013-07-01 07:04:06 UTC
It's basically the same issue on then two, and now three different pieces of hardware.

I've just re-mailed the patches to linux-kernel@vger.kernel.org:

 [PATCH 1/3] x86: Expand Dell OptiPlex 760 reboot quirk
 [PATCH 2/3] x86: add Dell OptiPlex 780 reboot quirk
 [PATCH 3/3] x86: add Dell OptiPlex 755 reboot quirk
Comment 10 Aaron Lu 2013-09-05 05:59:31 UTC
Hi Pascal,

I suppose these patches are similar to this one?

commit 6be30bb7d7504ec687a65c9bbdae8d1d2f8eaa19
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date:   Wed Nov 16 00:19:51 2011 +0100

    x86/reboot: Blacklist Dell OptiPlex 990 known to require PCI reboot
Comment 11 Pascal de Bruijn 2013-09-05 06:49:22 UTC
Created attachment 107424 [details]
[PATCH 1/3] x86: Expand Dell OptiPlex 760 reboot quirk

Rediffed patch.
Comment 12 Pascal de Bruijn 2013-09-05 06:49:49 UTC
Created attachment 107425 [details]
[PATCH 2/3] x86: add Dell OptiPlex 780 reboot quirk

Rediffed patch.
Comment 13 Pascal de Bruijn 2013-09-05 06:50:14 UTC
Created attachment 107426 [details]
[PATCH 3/3] x86: add Dell OptiPlex 755 reboot quirk

Rediffed patch
Comment 14 Pascal de Bruijn 2013-09-05 06:51:02 UTC
I've updated my full patch set. And they are very similar to 6be30bb7d7...
Comment 15 Aaron Lu 2013-09-05 07:20:45 UTC
Thanks Pascal. I just searched the mailing list, it turned out VT-d may be related. Can you please verify if disable VT-d solves the problem? Thanks.

http://marc.info/?l=linux-kernel&m=132667464420764&w=2
http://marc.info/?t=132173625600045&r=1&w=2

Note You need to log in before you can comment on or make changes to this bug.