Bug 5336 - Two the same fragments of code should be compacted to one
Two the same fragments of code should be compacted to one
Status: CLOSED CODE_FIX
Product: ACPI
Classification: Unclassified
Component: ACPICA-Core
i386 Linux
: P2 normal
Assigned To: Robert Moore
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-30 06:38 UTC by Valery A Podrezov
Modified: 2006-09-28 13:19 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6
Tree: Mainline
Regression: ---


Attachments
Proposed patch (1.94 KB, patch)
2005-09-30 06:41 UTC, Valery A Podrezov
Details | Diff

Description Valery A Podrezov 2005-09-30 06:38:35 UTC
Most recent kernel where this bug did not occur:
Distribution:
Hardware Environment:
Software Environment:
Problem Description:

Improve code of interpreter. 

Steps to reproduce:

Doesn't require.
Comment 1 Valery A Podrezov 2005-09-30 06:41:56 UTC
Created attachment 6195 [details]
Proposed patch


There are two the same fragments of code in the same routine
(AcpiExResolveMultiple, file interpreter/executer/exresolv.c)
which could be compacted to one. The patch attached provides
that minor update.

The only difference between the two fragments of code (34 lines each)
is like this:

   .............................
   <	     case AML_REF_OF_OP:
   ---
   >	     case AML_INT_NAMEPATH_OP:
   <		 Node = ObjDesc->Reference.Object;
   ---
   >		 Node = ObjDesc->Reference.Node;
   .............................


INTERNAL BUG NUMBER

   173
Comment 2 Robert Moore 2006-02-10 14:22:32 UTC
Released in ACPICA version 20060210
Comment 3 Len Brown 2006-06-25 21:59:44 UTC
ACPICA 20060608 shipped in Linux-2.6.17-git9, closed. 

Note You need to log in before you can comment on or make changes to this bug.