Bug 48891 - scsi/lpfc/lpfc_ct.c:637: possible finger trouble ?
Summary: scsi/lpfc/lpfc_ct.c:637: possible finger trouble ?
Status: RESOLVED CODE_FIX
Alias: None
Product: IO/Storage
Classification: Unclassified
Component: SCSI (show other bugs)
Hardware: All Linux
: P1 normal
Assignee: linux-scsi@vger.kernel.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-15 21:26 UTC by David Binderman
Modified: 2013-01-02 17:01 UTC (History)
2 users (show)

See Also:
Kernel Version: 3.7-rc1
Subsystem:
Regression: No
Bisected commit-id:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Binderman 2012-10-15 21:26:15 UTC 
[dcb@zippy linux-3.7-rc1]$ fgrep -n IOERR_PARAM_MASK drivers/scsi/lpfc/lpfc_ct.c
107:		   ((icmd->un.ulpWord[4] & IOERR_PARAM_MASK) ==
637:			    (irsp->un.ulpWord[4] && IOERR_PARAM_MASK) !=
789:					IOERR_PARAM_MASK)) {
915:			(((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==
917:			 ((irsp->un.ulpWord[4] & IOERR_PARAM_MASK) ==
[dcb@zippy linux-3.7-rc1]$ 

Line 637 looks wrong to me. && should possibly be &
Comment 1 James Smart 2012-10-31 19:03:04 UTC 
Thank You.

This problem has been addressed by patch6 of our 8.3.36 patch kit: See 
http://marc.info/?l=linux-scsi&m=135170916626123&w=2

-- james s



On 10/17/2012 6:24 AM, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=48891
>
>
> Alan <alan@lxorguk.ukuu.org.uk> changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |alan@lxorguk.ukuu.org.uk
>            Component|Other                       |SCSI
>           AssignedTo|drivers_other@kernel-bugs.o |linux-scsi@vger.kernel.org
>                     |sdl.org                     |
>              Product|Drivers                     |IO/Storage
>
>
>
>
Comment 2 Florian Mickler 2012-12-22 09:28:23 UTC 
A patch referencing this bug report has been merged in Linux v3.8-rc1:

commit edb22f06e08ac5b25ae2d9ad10ae31ac58ca0de4
Author: James Smart <james.smart@emulex.com>
Date:   Wed Oct 31 14:45:21 2012 -0400

    [SCSI] lpfc 8.3.36: Correct mask error
Note You need to log in before you can comment on or make changes to this bug.