Bug 4546 - [OPERA] Potential bug detected in fs/xfs/quota/xfs_trans_dquot.c
Summary: [OPERA] Potential bug detected in fs/xfs/quota/xfs_trans_dquot.c
Status: CLOSED CODE_FIX
Alias: None
Product: File System
Classification: Unclassified
Component: XFS (show other bugs)
Hardware: i386 Linux
: P2 normal
Assignee: XFS Guru
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-25 16:35 UTC by Zhenmin
Modified: 2005-08-09 10:59 UTC (History)
1 user (show)

See Also:
Kernel Version: 2.6.11.7
Tree: Mainline
Regression: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Zhenmin 2005-04-25 16:35:23 UTC 
Problem Description:
A potential bug is detected by our tool in linux-
2.6.11.7/fs/xfs/quota/xfs_trans_dquot.c:

--- xfs_trans_dquot.c   2005-04-25 18:32:00.000000000 -0500
+++ xfs_trans_dquot.fixed.c     2005-04-25 18:33:41.000000000 -0500
@@ -499,7 +499,7 @@
                         * Adjust the RT reservation.
                         */
                        if (qtrx->qt_rtblk_res != 0) {
-                               if (qtrx->qt_blk_res != qtrx->qt_blk_res_used) {
+                               if (qtrx->qt_rtblk_res != qtrx-
>qt_blk_res_used) {
                                        if (qtrx->qt_rtblk_res >
                                            qtrx->qt_rtblk_res_used)
                                               dqp->q_res_rtbcount -= 
(xfs_qcnt_t)
Comment 1 Nathan Scott 2005-04-26 00:01:01 UTC 
Hi there,

Yes, that fix is correct.  This is benign though, since its currently
not possible to mount realtime XFS subvolumes with quota enabled (and
realtime is still experimental anyway) - but, thanks, and I'll get it
merged shortly.

cheers.
Comment 2 Adrian Bunk 2005-08-09 10:59:05 UTC 
The patch has been included in 2.6.13-rc .
Note You need to log in before you can comment on or make changes to this bug.